From: Daniel Vetter <daniel@ffwll.ch>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane: Fix crop test
Date: Tue, 2 Apr 2019 11:02:41 +0200 [thread overview]
Message-ID: <20190402090241.GH2665@phenom.ffwll.local> (raw)
In-Reply-To: <20190401151707.4576-1-ville.syrjala@linux.intel.com>
On Mon, Apr 01, 2019 at 06:17:07PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Set the src/dst viewports correctly when trying to crop off the
> edges.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110296
> Fixes: 80eb61459791 ("tests/kms_plane: Remove the upscaling requirement")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Oops, bad review by me :-/
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
... but not sure how much value there is in that ...
-Daniel
> ---
> tests/kms_plane.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index 33e2905a8d71..471bcbeb8f77 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -436,8 +436,11 @@ static void test_format_plane_color(data_t *data, enum pipe pipe,
> /*
> * if clamping test. DRM_FORMAT_XRGB8888 is used for reference color.
> */
> - if (data->crop != 0 && format != DRM_FORMAT_XRGB8888)
> + if (data->crop != 0 && format != DRM_FORMAT_XRGB8888) {
> igt_fb_set_position(fb, plane, data->crop, data->crop);
> + igt_fb_set_size(fb, plane, width, height);
> + igt_plane_set_size(plane, width, height);
> + }
>
> igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_UNIVERSAL);
> igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, crc);
> --
> 2.19.2
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-04-02 9:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 15:17 [igt-dev] [PATCH i-g-t] tests/kms_plane: Fix crop test Ville Syrjala
2019-04-02 5:51 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-02 7:38 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-04-02 7:57 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
2019-04-02 9:02 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402090241.GH2665@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=igt-dev@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox