From: Daniel Vetter <daniel@ffwll.ch>
To: IGT development <igt-dev@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_color: Use igt_require more
Date: Wed, 3 Apr 2019 15:57:14 +0200 [thread overview]
Message-ID: <20190403135714.GJ2665@phenom.ffwll.local> (raw)
In-Reply-To: <20190403135042.24195-1-daniel.vetter@ffwll.ch>
On Wed, Apr 03, 2019 at 03:50:42PM +0200, Daniel Vetter wrote:
> Success is not the right status if the test does nothing. Fix that.
>
> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Mika Kahola <mika.kahola@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Please disregard, Ville has a patch covering this one already.
-Daniel
> ---
> tests/kms_color.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tests/kms_color.c b/tests/kms_color.c
> index decf3c2a680e..d2352cf8a9ba 100644
> --- a/tests/kms_color.c
> +++ b/tests/kms_color.c
> @@ -1135,8 +1135,7 @@ invalid_ctm_matrix_sizes(data_t *data)
> igt_pipe_t *pipe = &display->pipes[0];
> void *ptr;
>
> - if (!igt_pipe_obj_has_prop(pipe, IGT_CRTC_CTM))
> - return;
> + igt_require(igt_pipe_obj_has_prop(pipe, IGT_CRTC_CTM));
>
> ptr = malloc(sizeof(struct _drm_color_ctm) * 4);
>
> --
> 2.20.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-04-03 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 13:50 [igt-dev] [PATCH i-g-t] tests/kms_color: Use igt_require more Daniel Vetter
2019-04-03 13:57 ` Daniel Vetter [this message]
2019-04-03 14:47 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403135714.GJ2665@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox