From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6EE0A6E82D for ; Wed, 3 Apr 2019 14:23:15 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id d11so5351582edp.11 for ; Wed, 03 Apr 2019 07:23:15 -0700 (PDT) Date: Wed, 3 Apr 2019 16:23:11 +0200 From: Daniel Vetter Message-ID: <20190403142311.GL2665@phenom.ffwll.local> References: <20190219093800.4312-1-stanislav.lisovskiy@intel.com> <690c1112b0fd97f4810cced16d442d16ca75809b.camel@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <690c1112b0fd97f4810cced16d442d16ca75809b.camel@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t v4] igt/tests: Fix error checking in kms_atomic_transition List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Summers, Stuart" Cc: "Lisovskiy, Stanislav" , "Syrjala, Ville" , "norkernel@freedesktop.org" , "Peres, Martin" , "igt-dev@lists.freedesktop.org" , "Heikkila, Juha-pekka" List-ID: T24gVHVlLCBGZWIgMTksIDIwMTkgYXQgMDk6MDU6MTJQTSArMDAwMCwgU3VtbWVycywgU3R1YXJ0 IHdyb3RlOgo+IE9uIFR1ZSwgMjAxOS0wMi0xOSBhdCAxMTozOCArMDIwMCwgU3RhbmlzbGF2IExp c292c2tpeSB3cm90ZToKPiA+IEZyb206IFN0YW5pc2xhdiBMaXNvdnNraXkgPHN0YW5pc2xhdi5s aXNvdnNraXlAZ21haWwuY29tPgo+ID4gCj4gPiBUaGVyZSBpcyBubyBndWFyYW50ZWUgdGhhdCBl cnJvciByZXR1cm4gdmFsdWUgd2lsbCBiZQo+ID4gYWx3YXlzIEVJTlZBTCwgbWFkZSBhIGNoZWNr IG1vcmUgZ2VuZXJhbCBhcyBpdCBjYW4gYmUKPiA+IEVSQU5HRSwgRU5PU1BDLCBFSU5WQUwgYW5k IHByb2JhYmx5IG90aGVycywgd2hpY2ggYWxsCj4gPiBtZWFuIHRoZSBzYW1lIGluIGNvbnRleHQg b2YgdGhpcyB0ZXN0IGNhc2U6IGkuZSB0aGlzIHNwcml0ZQo+ID4gc2l6ZSBpcyBub3QgdmFsaWQu Cj4gPiAKPiA+IHYyOiBBZGRlZCBtYWNybyB0byBtYWtlIGNoZWNrIGxvb2sgYSBiaXQgbmljZXIu Cj4gPiB2MzogUmVtb3ZlZCByZWR1bmRhbnQgZGVidWcgbGluZS4KPiA+IHY0OiBBZGRlZCBhc3Nl cnRpb24gaWYgZXJyb3IgaXMgbm90IEVJTlZBTCBhcyBleHBlY3RlZCwKPiA+ICAgICBvdGhlciBl cnJvcnMgZXhjZXB0IEVJTlZBTCBhcmUgY29uc2lkZXJlZCBub3cgYSBmYWlsdXJlcy4KClVoLCBj b21taXQgbWVzc2FnZSBzYXlzIHRvIG1ha2UgdGhlIGVycm9yIG1lc3NhZ2UgbW9yZSBnZW5lcmFs LCBhbmQgdGhlbgpwcm9jZWVkcyB0byBtYWtlIGl0IG5vdCBtb3JlIGdlbmVyYWwuIFRoaXMga2lu ZCBvZiBpbmNvbnNpc3RlbmNpZXMgc2hvdWxkCmJlIGNhdWdodCBpbiByZXZpZXcuCgo+ID4gQnVn emlsbGE6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTIy NQo+ID4gU2lnbmVkLW9mZi1ieTogU3RhbmlzbGF2IExpc292c2tpeSA8c3RhbmlzbGF2Lmxpc292 c2tpeUBpbnRlbC5jb20+CgpBbmQgSSBhbHNvIGRvbid0IHVuZGVyc3RhbmQgaG93IHRoaXMgcGF0 Y2ggZml4ZWQgYW55dGhpbmcgcmVhbGx5LCB3ZSBzdGlsbApqdXN0IGNoZWNrIGZvciBFSU5WQUwu Ci1EYW5pZWwKCj4gPiAtLS0KPiA+ICB0ZXN0cy9rbXNfYXRvbWljX3RyYW5zaXRpb24uYyB8IDEz ICsrKysrKysrKysrLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMiBk ZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL3Rlc3RzL2ttc19hdG9taWNfdHJhbnNp dGlvbi5jCj4gPiBiL3Rlc3RzL2ttc19hdG9taWNfdHJhbnNpdGlvbi5jCj4gPiBpbmRleCAxMmJh ZmU4Ny4uZTFhMmQ0YTAgMTAwNjQ0Cj4gPiAtLS0gYS90ZXN0cy9rbXNfYXRvbWljX3RyYW5zaXRp b24uYwo+ID4gKysrIGIvdGVzdHMva21zX2F0b21pY190cmFuc2l0aW9uLmMKPiA+IEBAIC0xODcs NiArMTg3LDEyIEBAIHN0YXRpYyB2b2lkIHNldF9zcHJpdGVfd2goaWd0X2Rpc3BsYXlfdAo+ID4g KmRpc3BsYXksIGVudW0gcGlwZSBwaXBlLAo+ID4gIAkJICAgICAgTE9DQUxfRFJNX0ZPUk1BVF9N T0RfTk9ORSwgc3ByaXRlX2ZiKTsKPiA+ICB9Cj4gPiAgCj4gPiArI2RlZmluZSBpc19hdG9taWNf Y2hlY2tfZmFpbHVyZV9lcnJubyhlcnJubykgXAo+ID4gKwkJKGVycm5vICE9IC1FSU5WQUwgJiYg ZXJybm8gIT0gMCkKPiA+ICsKPiA+ICsjZGVmaW5lIGlzX2F0b21pY19jaGVja19wbGFuZV9zaXpl X2Vycm5vKGVycm5vKSBcCj4gPiArCQkoZXJybm8gPT0gLUVJTlZBTCkKPiA+ICsKPiA+ICBzdGF0 aWMgdm9pZCBzZXR1cF9wYXJtcyhpZ3RfZGlzcGxheV90ICpkaXNwbGF5LCBlbnVtIHBpcGUgcGlw ZSwKPiA+ICAJCQljb25zdCBkcm1Nb2RlTW9kZUluZm8gKm1vZGUsCj4gPiAgCQkJc3RydWN0IGln dF9mYiAqcHJpbWFyeV9mYiwKPiA+IEBAIC0yNTEsOCArMjU3LDkgQEAgcmV0cnk6Cj4gPiAgCj4g PiAgCQl3bV9zZXR1cF9wbGFuZShkaXNwbGF5LCBwaXBlLCAoMSA8PCBuX3BsYW5lcykgLSAxLAo+ ID4gcGFybXMsIGZhbHNlKTsKPiA+ICAJCXJldCA9IGlndF9kaXNwbGF5X3RyeV9jb21taXRfYXRv bWljKGRpc3BsYXksCj4gPiBEUk1fTU9ERV9BVE9NSUNfVEVTVF9PTkxZIHwgRFJNX01PREVfQVRP TUlDX0FMTE9XX01PREVTRVQsIE5VTEwpOwo+ID4gKwkJaWd0X2Fzc2VydCghaXNfYXRvbWljX2No ZWNrX2ZhaWx1cmVfZXJybm8ocmV0KSk7Cj4gPiAgCj4gPiAtCQlpZiAocmV0ID09IC1FSU5WQUwp IHsKPiA+ICsJCWlmIChpc19hdG9taWNfY2hlY2tfcGxhbmVfc2l6ZV9lcnJubyhyZXQpKSB7Cj4g PiAgCQkJaWYgKGN1cnNvcl93aWR0aCA9PSBzcHJpdGVfd2lkdGggJiYKPiA+ICAJCQkgICAgY3Vy c29yX2hlaWdodCA9PSBzcHJpdGVfaGVpZ2h0KSB7Cj4gPiAgCQkJCWlndF9hc3NlcnRfZihhbHBo YSwKPiA+IEBAIC00NDIsNyArNDQ5LDkgQEAgcnVuX3RyYW5zaXRpb25fdGVzdChpZ3RfZGlzcGxh eV90ICpkaXNwbGF5LCBlbnVtCj4gPiBwaXBlIHBpcGUsIGlndF9vdXRwdXRfdCAqb3V0cHV0Cj4g PiAgCQkJaWd0X3BpcGVfcmVxdWVzdF9vdXRfZmVuY2UocGlwZV9vYmopOwo+ID4gIAo+ID4gIAkJ cmV0ID0gaWd0X2Rpc3BsYXlfdHJ5X2NvbW1pdF9hdG9taWMoZGlzcGxheSwKPiA+IERSTV9NT0RF X0FUT01JQ19URVNUX09OTFkgfCBEUk1fTU9ERV9BVE9NSUNfQUxMT1dfTU9ERVNFVCwgTlVMTCk7 Cj4gPiAtCQlpZiAocmV0ICE9IC1FSU5WQUwgfHwgcGlwZV9vYmotPm5fcGxhbmVzIDwgMykKPiA+ ICsJCWlndF9hc3NlcnQoIWlzX2F0b21pY19jaGVja19mYWlsdXJlX2Vycm5vKHJldCkpOwo+ID4g Kwo+ID4gKwkJaWYgKCFpc19hdG9taWNfY2hlY2tfcGxhbmVfc2l6ZV9lcnJubyhyZXQpIHx8IHBp cGVfb2JqLQo+ID4gPm5fcGxhbmVzIDwgMykKPiA+ICAJCQlicmVhazsKPiA+ICAKPiA+ICAJCXJl dCA9IDA7Cj4gCj4gTEdUTQo+IAo+IFJldmlld2VkLWJ5OiBTdHVhcnQgU3VtbWVycyA8c3R1YXJ0 LnN1bW1lcnNAaW50ZWwuY29tPgoKCgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCj4gaWd0LWRldiBtYWlsaW5nIGxpc3QKPiBpZ3QtZGV2QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaWd0LWRldgoKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRl bCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2lndC1kZXY=