From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E5C16E9DC for ; Thu, 4 Apr 2019 08:10:51 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id d26so1307804ede.10 for ; Thu, 04 Apr 2019 01:10:51 -0700 (PDT) Date: Thu, 4 Apr 2019 10:10:46 +0200 From: Daniel Vetter Message-ID: <20190404081046.GQ2665@phenom.ffwll.local> References: <20190219093800.4312-1-stanislav.lisovskiy@intel.com> <690c1112b0fd97f4810cced16d442d16ca75809b.camel@intel.com> <20190403142311.GL2665@phenom.ffwll.local> <126e6a048495814781d60526fc7fc813158d821c.camel@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <126e6a048495814781d60526fc7fc813158d821c.camel@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t v4] igt/tests: Fix error checking in kms_atomic_transition List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Lisovskiy, Stanislav" Cc: "norkernel@freedesktop.org" , "Syrjala, Ville" , "igt-dev@lists.freedesktop.org" , "Peres, Martin" , "Heikkila, Juha-pekka" , "daniel@ffwll.ch" List-ID: T24gVGh1LCBBcHIgMDQsIDIwMTkgYXQgMDc6MzM6MzFBTSArMDAwMCwgTGlzb3Zza2l5LCBTdGFu aXNsYXYgd3JvdGU6Cj4gT24gV2VkLCAyMDE5LTA0LTAzIGF0IDE2OjIzICswMjAwLCBEYW5pZWwg VmV0dGVyIHdyb3RlOgo+ID4gT24gVHVlLCBGZWIgMTksIDIwMTkgYXQgMDk6MDU6MTJQTSArMDAw MCwgU3VtbWVycywgU3R1YXJ0IHdyb3RlOgo+ID4gPiBPbiBUdWUsIDIwMTktMDItMTkgYXQgMTE6 MzggKzAyMDAsIFN0YW5pc2xhdiBMaXNvdnNraXkgd3JvdGU6Cj4gPiA+ID4gRnJvbTogU3Rhbmlz bGF2IExpc292c2tpeSA8c3RhbmlzbGF2Lmxpc292c2tpeUBnbWFpbC5jb20+Cj4gPiA+ID4gCj4g PiA+ID4gVGhlcmUgaXMgbm8gZ3VhcmFudGVlIHRoYXQgZXJyb3IgcmV0dXJuIHZhbHVlIHdpbGwg YmUKPiA+ID4gPiBhbHdheXMgRUlOVkFMLCBtYWRlIGEgY2hlY2sgbW9yZSBnZW5lcmFsIGFzIGl0 IGNhbiBiZQo+ID4gPiA+IEVSQU5HRSwgRU5PU1BDLCBFSU5WQUwgYW5kIHByb2JhYmx5IG90aGVy cywgd2hpY2ggYWxsCj4gPiA+ID4gbWVhbiB0aGUgc2FtZSBpbiBjb250ZXh0IG9mIHRoaXMgdGVz dCBjYXNlOiBpLmUgdGhpcyBzcHJpdGUKPiA+ID4gPiBzaXplIGlzIG5vdCB2YWxpZC4KPiA+ID4g PiAKPiA+ID4gPiB2MjogQWRkZWQgbWFjcm8gdG8gbWFrZSBjaGVjayBsb29rIGEgYml0IG5pY2Vy Lgo+ID4gPiA+IHYzOiBSZW1vdmVkIHJlZHVuZGFudCBkZWJ1ZyBsaW5lLgo+ID4gPiA+IHY0OiBB ZGRlZCBhc3NlcnRpb24gaWYgZXJyb3IgaXMgbm90IEVJTlZBTCBhcyBleHBlY3RlZCwKPiA+ID4g PiAgICAgb3RoZXIgZXJyb3JzIGV4Y2VwdCBFSU5WQUwgYXJlIGNvbnNpZGVyZWQgbm93IGEgZmFp bHVyZXMuCj4gPiAKPiA+IFVoLCBjb21taXQgbWVzc2FnZSBzYXlzIHRvIG1ha2UgdGhlIGVycm9y IG1lc3NhZ2UgbW9yZSBnZW5lcmFsLCBhbmQKPiA+IHRoZW4KPiA+IHByb2NlZWRzIHRvIG1ha2Ug aXQgbm90IG1vcmUgZ2VuZXJhbC4gVGhpcyBraW5kIG9mIGluY29uc2lzdGVuY2llcwo+ID4gc2hv dWxkCj4gPiBiZSBjYXVnaHQgaW4gcmV2aWV3Lgo+IAo+IEhpIERhbmllbCwKPiAKPiBBcyB0aGUg Y29tbWl0IG1lc3NhZ2Ugc2F5cywgcHJldmlzb3VseSB3ZSB3ZXJlIGV4cGVjdGluZyBvbmx5Cj4g RUlOVkFMKHdoaWNoIGluZGljYXRlcyBmb3IKPiB1cyB0aGF0IHdlIGhhZCByZWFjaGVkIG1heCBz aXplIG9mIGEgcGxhbmUpIG9yIDAuCj4gCj4gUHJvYmxlbSB3YXMgdGhhdCBpbiBzb21lIGNpcmN1 bXN0YW5jZXMsIGlmIHdlIGdldCBzb21ldGhpbmcgZWxzZQo+IHRlc3QgY2FzZSBkaWQgbm90IGNh dGNoIHRoYXQgYW5kIHByb2NlZWRlZCBhcyBpZiBldmVyeXRoaW5nIGlzCj4gZ3JlYXQsIGZhaWxp bmcgYWZ0ZXJ3YXJkcywgd2hlbiB0cnlpbmcgYWxyZWFkeSB0byBjb21taXQgb3Igb3RoZXIKPiBw bGFjZS4KPiBUaGUgdGhpbmcgd2hpY2ggdGhpcyBwYXRjaCBkb2VzIGlzIGFzIHNhaWQgIkFkZGVk IGFzc2VydGlvbiBpZiBlcnJvciBpcwo+IG5vdCBFSU5WQUwgYXMgZXhwZWN0ZWQsIG90aGVyIGVy cm9ycyBleGNlcHQgRUlOVkFMIGFyZSBjb25zaWRlcmVkIG5vdyBhCj4gZmFpbHVyZXMiLiBPdGhl cndpc2UgaWYgd2UgZ290IEVJTlZBTCwgd2UgcHJvY2VlZCBub3JtYWxseS4KPiAKPiBUaGVyZSB3 YXMgYWN0dWFsbHkgbm8gcHVycG9zZSB0byAiZml4IiBzb21ldGhpbmcgYnkgdGhhdCwgYnV0IHJh dGhlcgo+IG1ha2UgaXQgZmFpbCBpbiBhIHByb3BlciBwbGFjZSBhbmQgcHJvcGVyIHdheSwgb3Ro ZXJ3aXNlIGVycm9yIGp1c3QKPiB3ZW50IGZ1cnRoZXIuIAo+IAo+IE15IGluaXRpYWwgaWRlYSBh Y3R1YWxseSB3YXMgdG8gY2F0Y2ggYWxsIGtpbmQgb2YgcHJvYmxlbXMgaGVyZSwgc28KPiB0aGF0 IHdlIGFsd2F5cyBnZXQgc29tZSBraW5kIG9mIHdvcmtpbmcgcGxhbmUgY29uZmlndXJhdGlvbiBo ZXJlLgo+IEhvd2V2ZXIgaXQgd2FzIG5vdCBhY2NlcHRlZCBhbmQgY3VycmVudGx5IG9ubHkgRUlO VkFMIGlzIHRyZWF0ZWQgYXMKPiAibm9ybWFsIiBlcnJvci4KPiAKPiBJZiB5b3UgaGF2ZSBhbnkg cHJvcG9zYWxzLCBob3cgdGhpcyBjYW4gYmUgaW1wcm92ZWQgc3VyZSBJIGNhbiBkbyB0aGlzLgoK WWVhaCBJIHRoaW5rIHRoZSBwYXRjaCBpcyBmaW5lLCBidXQgdGhlIGNvbW1pdCBtZXNzYWdlIGlz bid0IHRoZSBjbGVhcmVzdCwKc2luY2UgaXQgZXhwbGFpbnMgd2hhdCBleGFjdGx5IGFuIGludGVy aW0gdmVyc2lvbiBkaWQsIGFuZCB0aGVuIGFtZW5kcwp0aGF0LiBXaGljaCBpcyBjb25mdXNpbmcu CgpZb3UncmUgZXhwbGFuYXRpb24gYWJvdmUgd291bGQgaGF2ZSBtYWRlIGEgbXVjaCBiZXR0ZXIg Y29tbWl0IG1lc3NhZ2UsIGJ1dApvaCB3ZWxsIHRoZSBwYXRjaCBpcyBjb21taXR0ZWQgc28gY2Fu J3QgZml4IHRoYXQgdXAgYW55bW9yZS4gQnV0IGdvb2QgdG8KaGVlZCBmb3IgbmV4dCB0aW1lIGFy b3VuZCwgcmV2aWV3IHNob3VsZCBhbHNvIG1ha2Ugc3VyZSB0aGUgY29tbWl0IG1lc3NhZ2UKY2Fw dHVyZXMgZXZlcnl0aGluZyBkaXNjdXNzZWQgYXMgd2VsbCBhcyBwb3NzaWJsZS4KCkNoZWVycywg RGFuaWVsCj4gCj4gPiAKPiA+ID4gPiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9w Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5MjI1Cj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogU3Rhbmlz bGF2IExpc292c2tpeSA8c3RhbmlzbGF2Lmxpc292c2tpeUBpbnRlbC5jb20KPiA+ID4gPiA+Cj4g PiAKPiA+IEFuZCBJIGFsc28gZG9uJ3QgdW5kZXJzdGFuZCBob3cgdGhpcyBwYXRjaCBmaXhlZCBh bnl0aGluZyByZWFsbHksIHdlCj4gPiBzdGlsbAo+ID4ganVzdCBjaGVjayBmb3IgRUlOVkFMLgo+ ID4gLURhbmllbAo+ID4gCj4gPiA+ID4gLS0tCj4gPiA+ID4gIHRlc3RzL2ttc19hdG9taWNfdHJh bnNpdGlvbi5jIHwgMTMgKysrKysrKysrKystLQo+ID4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMTEg aW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiA+ID4gPiAKPiA+ID4gPiBkaWZmIC0tZ2l0 IGEvdGVzdHMva21zX2F0b21pY190cmFuc2l0aW9uLmMKPiA+ID4gPiBiL3Rlc3RzL2ttc19hdG9t aWNfdHJhbnNpdGlvbi5jCj4gPiA+ID4gaW5kZXggMTJiYWZlODcuLmUxYTJkNGEwIDEwMDY0NAo+ ID4gPiA+IC0tLSBhL3Rlc3RzL2ttc19hdG9taWNfdHJhbnNpdGlvbi5jCj4gPiA+ID4gKysrIGIv dGVzdHMva21zX2F0b21pY190cmFuc2l0aW9uLmMKPiA+ID4gPiBAQCAtMTg3LDYgKzE4NywxMiBA QCBzdGF0aWMgdm9pZCBzZXRfc3ByaXRlX3doKGlndF9kaXNwbGF5X3QKPiA+ID4gPiAqZGlzcGxh eSwgZW51bSBwaXBlIHBpcGUsCj4gPiA+ID4gIAkJICAgICAgTE9DQUxfRFJNX0ZPUk1BVF9NT0Rf Tk9ORSwgc3ByaXRlX2ZiKTsKPiA+ID4gPiAgfQo+ID4gPiA+ICAKPiA+ID4gPiArI2RlZmluZSBp c19hdG9taWNfY2hlY2tfZmFpbHVyZV9lcnJubyhlcnJubykgXAo+ID4gPiA+ICsJCShlcnJubyAh PSAtRUlOVkFMICYmIGVycm5vICE9IDApCj4gPiA+ID4gKwo+ID4gPiA+ICsjZGVmaW5lIGlzX2F0 b21pY19jaGVja19wbGFuZV9zaXplX2Vycm5vKGVycm5vKSBcCj4gPiA+ID4gKwkJKGVycm5vID09 IC1FSU5WQUwpCj4gPiA+ID4gKwo+ID4gPiA+ICBzdGF0aWMgdm9pZCBzZXR1cF9wYXJtcyhpZ3Rf ZGlzcGxheV90ICpkaXNwbGF5LCBlbnVtIHBpcGUgcGlwZSwKPiA+ID4gPiAgCQkJY29uc3QgZHJt TW9kZU1vZGVJbmZvICptb2RlLAo+ID4gPiA+ICAJCQlzdHJ1Y3QgaWd0X2ZiICpwcmltYXJ5X2Zi LAo+ID4gPiA+IEBAIC0yNTEsOCArMjU3LDkgQEAgcmV0cnk6Cj4gPiA+ID4gIAo+ID4gPiA+ICAJ CXdtX3NldHVwX3BsYW5lKGRpc3BsYXksIHBpcGUsICgxIDw8IG5fcGxhbmVzKSAtIDEsCj4gPiA+ ID4gcGFybXMsIGZhbHNlKTsKPiA+ID4gPiAgCQlyZXQgPSBpZ3RfZGlzcGxheV90cnlfY29tbWl0 X2F0b21pYyhkaXNwbGF5LAo+ID4gPiA+IERSTV9NT0RFX0FUT01JQ19URVNUX09OTFkgfCBEUk1f TU9ERV9BVE9NSUNfQUxMT1dfTU9ERVNFVCwgTlVMTCk7Cj4gPiA+ID4gKwkJaWd0X2Fzc2VydCgh aXNfYXRvbWljX2NoZWNrX2ZhaWx1cmVfZXJybm8ocmV0KSk7Cj4gPiA+ID4gIAo+ID4gPiA+IC0J CWlmIChyZXQgPT0gLUVJTlZBTCkgewo+ID4gPiA+ICsJCWlmIChpc19hdG9taWNfY2hlY2tfcGxh bmVfc2l6ZV9lcnJubyhyZXQpKSB7Cj4gPiA+ID4gIAkJCWlmIChjdXJzb3Jfd2lkdGggPT0gc3By aXRlX3dpZHRoICYmCj4gPiA+ID4gIAkJCSAgICBjdXJzb3JfaGVpZ2h0ID09IHNwcml0ZV9oZWln aHQpIHsKPiA+ID4gPiAgCQkJCWlndF9hc3NlcnRfZihhbHBoYSwKPiA+ID4gPiBAQCAtNDQyLDcg KzQ0OSw5IEBAIHJ1bl90cmFuc2l0aW9uX3Rlc3QoaWd0X2Rpc3BsYXlfdCAqZGlzcGxheSwKPiA+ ID4gPiBlbnVtCj4gPiA+ID4gcGlwZSBwaXBlLCBpZ3Rfb3V0cHV0X3QgKm91dHB1dAo+ID4gPiA+ ICAJCQlpZ3RfcGlwZV9yZXF1ZXN0X291dF9mZW5jZShwaXBlX29iaik7Cj4gPiA+ID4gIAo+ID4g PiA+ICAJCXJldCA9IGlndF9kaXNwbGF5X3RyeV9jb21taXRfYXRvbWljKGRpc3BsYXksCj4gPiA+ ID4gRFJNX01PREVfQVRPTUlDX1RFU1RfT05MWSB8IERSTV9NT0RFX0FUT01JQ19BTExPV19NT0RF U0VULCBOVUxMKTsKPiA+ID4gPiAtCQlpZiAocmV0ICE9IC1FSU5WQUwgfHwgcGlwZV9vYmotPm5f cGxhbmVzIDwgMykKPiA+ID4gPiArCQlpZ3RfYXNzZXJ0KCFpc19hdG9taWNfY2hlY2tfZmFpbHVy ZV9lcnJubyhyZXQpKTsKPiA+ID4gPiArCj4gPiA+ID4gKwkJaWYgKCFpc19hdG9taWNfY2hlY2tf cGxhbmVfc2l6ZV9lcnJubyhyZXQpIHx8IHBpcGVfb2JqLQo+ID4gPiA+ID4gbl9wbGFuZXMgPCAz KQo+ID4gPiA+IAo+ID4gPiA+ICAJCQlicmVhazsKPiA+ID4gPiAgCj4gPiA+ID4gIAkJcmV0ID0g MDsKPiA+ID4gCj4gPiA+IExHVE0KPiA+ID4gCj4gPiA+IFJldmlld2VkLWJ5OiBTdHVhcnQgU3Vt bWVycyA8c3R1YXJ0LnN1bW1lcnNAaW50ZWwuY29tPgo+ID4gCj4gPiAKPiA+IAo+ID4gPiBfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gPiBpZ3QtZGV2 IG1haWxpbmcgbGlzdAo+ID4gPiBpZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gPiBo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXYKPiA+ IAo+ID4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9y YXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pZ3QtZGV2