public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: IGT development <igt-dev@lists.freedesktop.org>
Cc: "Peres, Martin" <martin.peres@intel.com>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: [igt-dev] [PATCH i-g-t] tests/kms_flip: Improve asserts for expired vblank tests
Date: Thu,  4 Apr 2019 13:33:00 +0200	[thread overview]
Message-ID: <20190404113300.10527-1-daniel.vetter@ffwll.ch> (raw)

Step 1 in debugging: Actually understand what's going wrong.

References: https://bugs.freedesktop.org/show_bug.cgi?id=102887
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: "Peres, Martin" <martin.peres@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 tests/kms_flip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index dfa5a69e8f28..7c2aa0c02a0e 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -681,7 +681,7 @@ static unsigned int run_test_step(struct test_output *o)
 					    TEST_VBLANK_BLOCK, o->pipe, exp_seq,
 					    0, &reply));
 		igt_assert(gettime_us() - start < 500);
-		igt_assert(reply.sequence == exp_seq);
+		igt_assert_eq(reply.sequence, exp_seq);
 		igt_assert(timercmp(&reply.ts, &o->flip_state.last_ts, ==));
 	}
 
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2019-04-04 11:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04 11:33 Daniel Vetter [this message]
2019-04-04 11:42 ` [igt-dev] [PATCH i-g-t] tests/kms_flip: Improve asserts for expired vblank tests Chris Wilson
2019-04-24  8:28   ` Daniel Vetter
2019-04-04 13:51 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-05  4:27 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190404113300.10527-1-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=martin.peres@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox