Re: [igt-dev] [PATCH i-g-t] tests/kms_fbcon_fbt: Do a full connector probe.

Souza, Jose
2019-02-05T18:45:02Z

[-- Attachment #1.1: Type: text/plain, Size: 1894 bytes --]

On Mon, 2019-02-04 at 12:55 -0800, Dhinakaran Pandiyan wrote:
> kms_fbtcon_fbt appears to fail when it is the first test that is
> executed
> after module load.
> 'Test requirement not met in function set_mode_for_one_screen, file
> ../tests/kms_fbcon_fbt.c:153:
> Test requirement: i < drm->res->count_connectors'
> The problem seems to be that the 1920x1080 bios fb is re-used and
> that
> prunes the 4k mode before test execution. Later, when the test does
> not
> do a full-probe, the eDP connector does not have any valid modes.

drmModeGetConnectorCurrent() will get only one mode, the active one.

>
> <7>[ 12.444411] [drm:drm_mode_debug_printmodeline] Modeline
> 191:"3840x2160" 60 533250 3840 3888 3920 4000 2160 2163 2168 2222
> 0x48
> 0xa
> <7>[ 12.444418] [drm:drm_mode_prune_invalid] Not using 3840x2160
> mode:
> VIRTUAL_X
>
> Fix this by calling drmModeGetConnector() instead
> drmModeGetConnectorCurrent()
>
> Note that that test is still expected to fail as PSR status checks
> are
> broken.

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109518
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
> tests/kms_fbcon_fbt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c
> index 9d0d5a36..40465a1c 100644
> --- a/tests/kms_fbcon_fbt.c
> +++ b/tests/kms_fbcon_fbt.c
> @@ -67,7 +67,7 @@ static void setup_drm(struct drm_info *drm)
> igt_assert(drm->res->count_connectors <= MAX_CONNECTORS);
>
> for (i = 0; i < drm->res->count_connectors; i++)
> - drm->connectors[i] = drmModeGetConnectorCurrent(drm-
> >fd,
> + drm->connectors[i] = drmModeGetConnector(drm->fd,
> drm->res-
> >connectors[i]);
>
> kmstest_set_vt_graphics_mode();

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]