Re: [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Check supported format for rotation

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Mon, Apr 08, 2019 at 02:45:29PM +0300, Mika Kahola wrote:
> Let's check if 90/270 rotation is supported for the format that we are
> trying to test.
> 
> Currently, if we try to test unsupported format the kernel complains with
> the following message.
> 
> "[drm:skl_plane_check [i915]] Unsupported pixel format Y210
> little-endian (0x30313259) for 90/270!"
> 
> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  tests/kms_plane_scaling.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 3364073c..bb14b2cd 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -144,9 +144,6 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
>  	igt_output_set_pipe(output, pipe);
>  	mode = igt_output_get_mode(output);
>  
> -	igt_skip_on(!igt_plane_has_format_mod(plane, pixel_format,
> -					      tiling));
> -
>  	/* create buffer in the range of  min and max source side limit.*/
>  	width = height = 8;
>  	if (is_i915_device(d->drm_fd) && is_planar_yuv_format(pixel_format))
> @@ -201,6 +198,7 @@ static void test_scaler_with_rotation_pipe(data_t *d, enum pipe pipe,
>  			for (int j = 0; j < plane->drm_plane->count_formats; j++) {
>  				unsigned format = plane->drm_plane->formats[j];
>  				if (igt_fb_supported_format(format) &&
> +				    igt_plane_has_format_mod(plane, format, tiling) &&
>  				    can_rotate(d, format))
>  					check_scaling_pipe_plane_rot(d, plane, format,
>  								     tiling, pipe,
> -- 
> 2.17.1

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev