From: "José Roberto de Souza" <jose.souza@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v2 2/2] tests/kms_atomic_transition: Remove useless code
Date: Mon, 8 Apr 2019 12:59:52 -0700 [thread overview]
Message-ID: <20190408195952.17061-2-jose.souza@intel.com> (raw)
In-Reply-To: <20190408195952.17061-1-jose.souza@intel.com>
setup_parms() already makes sure that overlay planes size is supported
by driver and GPU, no need to re-run it.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
tests/kms_atomic_transition.c | 39 -----------------------------------
1 file changed, 39 deletions(-)
diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
index c5127ad7..021a5ae7 100644
--- a/tests/kms_atomic_transition.c
+++ b/tests/kms_atomic_transition.c
@@ -471,7 +471,6 @@ run_transition_test(igt_display_t *display, enum pipe pipe, igt_output_t *output
uint32_t iter_max, i;
struct plane_parms parms[pipe_obj->n_planes];
unsigned flags = 0;
- int ret;
if (fencing)
prepare_fencing(display, pipe);
@@ -508,44 +507,6 @@ run_transition_test(igt_display_t *display, enum pipe pipe, igt_output_t *output
setup_parms(display, pipe, mode, &fb, &argb_fb, &sprite_fb, parms, &iter_max);
- /*
- * In some configurations the tests may not run to completion with all
- * sprite planes lit up at 4k resolution, try decreasing width/size of secondary
- * planes to fix this
- */
- while (1) {
- wm_setup_plane(display, pipe, iter_max - 1, parms, false);
-
- if (fencing)
- igt_pipe_request_out_fence(pipe_obj);
-
- ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY | DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
- igt_assert(!is_atomic_check_failure_errno(ret));
-
- if (!is_atomic_check_plane_size_errno(ret) || pipe_obj->n_planes < 3)
- break;
-
- ret = 0;
- for_each_plane_on_pipe(display, pipe, plane) {
- i = plane->index;
-
- if (plane->type == DRM_PLANE_TYPE_PRIMARY ||
- plane->type == DRM_PLANE_TYPE_CURSOR)
- continue;
-
- if (parms[i].width <= 512)
- continue;
-
- parms[i].width /= 2;
- ret = 1;
- igt_info("Reducing sprite %i to %ux%u\n", i - 1, parms[i].width, parms[i].height);
- break;
- }
-
- if (!ret)
- igt_skip("Cannot run tests without proper size sprite planes\n");
- }
-
igt_display_commit2(display, COMMIT_ATOMIC);
if (type == TRANSITION_AFTER_FREE) {
--
2.21.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-04-08 19:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 19:59 [igt-dev] [PATCH i-g-t v2 1/2] HAX: tests/kms_atomic_transition: Don't test more planes than memory bandwidth can support José Roberto de Souza
2019-04-08 19:59 ` José Roberto de Souza [this message]
2019-04-08 20:37 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/2] " Patchwork
2019-04-09 1:25 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408195952.17061-2-jose.souza@intel.com \
--to=jose.souza@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox