From: Imre Deak <imre.deak@intel.com>
To: Manasi Navare <manasi.d.navare@intel.com>
Cc: igt-dev@lists.freedesktop.org,
Anusha Srivatsa <anusha.srivatsa@intel.com>,
Petri Latvala <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t v2] tests/kms_dp_dsc: Force a full modeset when we force dsc enable
Date: Mon, 8 Apr 2019 23:48:59 +0300 [thread overview]
Message-ID: <20190408204859.GC21909@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <20190408203927.GA21909@ideak-desk.fi.intel.com>
On Mon, Apr 08, 2019 at 11:39:27PM +0300, Imre Deak wrote:
> On Mon, Apr 08, 2019 at 12:06:37PM -0700, Manasi Navare wrote:
> > On Mon, Apr 08, 2019 at 03:08:05PM +0300, Imre Deak wrote:
> > > On Fri, Apr 05, 2019 at 03:55:49PM -0700, Manasi Navare wrote:
> > > > DSC enable gets configured during compute_config and needs
> > > > a full modeset to force DSC.
> > > > Sometimes in between the tests, if the initial output is same as the
> > > > mode being set for DSC then it will not do a full modeset.
> > > > So we disable the output before forcing a mode with DSC enable.
> > > >
> > > > You need the kernel patch:
> > > > https://patchwork.freedesktop.org/series/59084/
> > > >
> > > > v2:
> > > > * Restore the value of force dsc enable after the test and in igt_exit_handler
> > > > * Add igt_install_exit_handler to restore values on fail/exit
Also, please split the fix restoring force_dsc_en into a separate patch.
--Imre
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-04-08 20:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 22:55 [igt-dev] [PATCH i-g-t v2] tests/kms_dp_dsc: Force a full modeset when we force dsc enable Manasi Navare
2019-04-05 23:30 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_dp_dsc: Force a full modeset when we force dsc enable (rev2) Patchwork
2019-04-06 23:22 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-04-08 12:08 ` [igt-dev] [PATCH i-g-t v2] tests/kms_dp_dsc: Force a full modeset when we force dsc enable Imre Deak
2019-04-08 19:06 ` Manasi Navare
2019-04-08 20:39 ` Imre Deak
2019-04-08 20:48 ` Imre Deak [this message]
2019-04-08 22:17 ` Manasi Navare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408204859.GC21909@ideak-desk.fi.intel.com \
--to=imre.deak@intel.com \
--cc=anusha.srivatsa@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=manasi.d.navare@intel.com \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox