From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Mika Kahola <mika.kahola@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Check supported pixel format
Date: Tue, 9 Apr 2019 15:52:47 +0300 [thread overview]
Message-ID: <20190409125247.GM3888@intel.com> (raw)
In-Reply-To: <20190409122930.4262-1-mika.kahola@intel.com>
On Tue, Apr 09, 2019 at 03:29:30PM +0300, Mika Kahola wrote:
> Let's add a check for supported pixel format. Otherwise, we fail the test,
> for example, with the following error message
>
> "[drm:intel_framebuffer_init [i915]] unsupported pixel format Y210 little-endian
> (0x30313259) / modifier 0x100000000000003"
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110369
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tests/kms_plane_scaling.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index bb14b2cd..e843bf86 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -232,7 +232,8 @@ static void test_scaler_with_pixel_format_pipe(data_t *d, enum pipe pipe, igt_ou
> for (int j = 0; j < plane->drm_plane->count_formats; j++) {
> uint32_t format = plane->drm_plane->formats[j];
>
> - if (igt_fb_supported_format(format))
> + if (igt_fb_supported_format(format) &&
> + igt_plane_has_format_mod(plane, format, tiling))
> check_scaling_pipe_plane_rot(d, plane,
> format, tiling,
> pipe, output, IGT_ROTATION_0);
> --
> 2.17.1
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-04-09 12:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 12:29 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Check supported pixel format Mika Kahola
2019-04-09 12:52 ` Ville Syrjälä [this message]
2019-04-10 7:22 ` Kahola, Mika
2019-04-09 14:07 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-09 20:55 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409125247.GM3888@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox