public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 1/3] kms_flip: Make busy-flip test less strict.
Date: Wed, 10 Apr 2019 13:19:29 +0200	[thread overview]
Message-ID: <20190410111931.28305-1-maarten.lankhorst@linux.intel.com> (raw)

Remove the -interruptible test, the test only tests that we get an
-EBUSY after doing a pageflip. Doing this interruptibly adds the
possibility the test will take too long from retrying.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 tests/kms_flip.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index dfa5a69e8f28..08f3bd29b8eb 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1575,6 +1575,13 @@ int main(int argc, char **argv)
 		    !(tests[i].flags & TEST_VBLANK_ABSOLUTE))
 			continue;
 
+		/*
+		 * -EBUSY needs to complete in a single vblank, skip them for
+		 * interruptible tests
+		 */
+		if (tests[i].flags & TEST_EBUSY)
+			continue;
+
 		igt_subtest_f( "%s-interruptible", tests[i].name)
 			run_test(tests[i].duration, tests[i].flags);
 
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2019-04-10 11:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-10 11:19 Maarten Lankhorst [this message]
2019-04-10 11:19 ` [igt-dev] [PATCH i-g-t 2/3] tests/kms_flip: Reduce runtime to 1s for busy-flip Maarten Lankhorst
2019-04-10 11:19 ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_flip: Do not request event for flips we expect to fail Maarten Lankhorst
2019-04-10 11:24   ` Chris Wilson
2019-04-10 12:44     ` Maarten Lankhorst
2019-04-10 12:50       ` Chris Wilson
2019-04-10 15:52         ` Maarten Lankhorst
2019-04-10 12:19 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] kms_flip: Make busy-flip test less strict Patchwork
2019-04-10 15:39 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190410111931.28305-1-maarten.lankhorst@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox