Re: [igt-dev] [PATCH v20 2/6] lib/i915: add gem_engine_topology library and for_each loop definition

Andi Shyti
2019-04-12T15:32:55Z

> > +int64_t gem_map_all_engines(int fd)
>
> int64_t?

yeah... should be uint32_t, I forgot gem_context_create had some
igt_requires, I thought 32 bit for ctx_id and the rest for
-errno.

I don't even need 'gem_require_contexts()', because it
basically does the same thing of 'gem_context_create()'

> There's no indication this creates a context.
>
> int gem_context_map_all_engines(int i915, uint32_t ctx)

I wanted the caller not to care about the context. I can probably
call it 'gem_create_populated_context()'?

> {
> /* ... */
> return param.num_engines;
> }
>
> map? set, expose, populate

my bad naming skills :)

Thanks, Chris,
Andi

> -Chris