public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi@etezian.org>
To: IGT dev <igt-dev@lists.freedesktop.org>
Cc: Andi Shyti <andi@etezian.org>
Subject: [igt-dev] [PATCH v20 4/6] lib: igt_gt: make gem_engine_can_store_dword() check engine class
Date: Fri, 12 Apr 2019 03:32:08 +0300	[thread overview]
Message-ID: <20190412003210.18762-5-andi@etezian.org> (raw)
In-Reply-To: <20190412003210.18762-1-andi@etezian.org>

From: Andi Shyti <andi.shyti@intel.com>

Engines referred by class and instance are getting more populare,
gem_engine_can_store_dword() should handle the situation.

Suggested-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Andi Shyti <andi.shyti@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 lib/igt_gt.c | 11 ++++++++---
 lib/igt_gt.h |  1 +
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/lib/igt_gt.c b/lib/igt_gt.c
index 8cd58f7afbfd..5d0a8e8060a7 100644
--- a/lib/igt_gt.c
+++ b/lib/igt_gt.c
@@ -557,7 +557,7 @@ const struct intel_execution_engine intel_execution_engines[] = {
 	{ NULL, 0, 0 }
 };
 
-bool gem_can_store_dword(int fd, unsigned int engine)
+bool gem_class_can_store_dword(int fd, int class)
 {
 	uint16_t devid = intel_get_drm_devid(fd);
 	const struct intel_device_info *info = intel_get_device_info(devid);
@@ -569,8 +569,8 @@ bool gem_can_store_dword(int fd, unsigned int engine)
 	if (gen == 3 && (info->is_grantsdale || info->is_alviso))
 		return false; /* only supports physical addresses */
 
-	if (gen == 6 && ((engine & 0x3f) == I915_EXEC_BSD))
-		return false; /* kills the machine! */
+	if (gen == 6 && class == I915_ENGINE_CLASS_VIDEO)
+		return false;
 
 	if (info->is_broadwater)
 		return false; /* Not sure yet... */
@@ -578,6 +578,11 @@ bool gem_can_store_dword(int fd, unsigned int engine)
 	return true;
 }
 
+bool gem_can_store_dword(int fd, unsigned int engine)
+{
+	return gem_class_can_store_dword(fd, gem_eb_to_class(engine));
+}
+
 const struct intel_execution_engine2 intel_execution_engines2[] = {
 	{ "rcs0", I915_ENGINE_CLASS_RENDER, 0 },
 	{ "bcs0", I915_ENGINE_CLASS_COPY, 0 },
diff --git a/lib/igt_gt.h b/lib/igt_gt.h
index b13062ef7d33..af4cc38a1ef7 100644
--- a/lib/igt_gt.h
+++ b/lib/igt_gt.h
@@ -90,6 +90,7 @@ bool gem_ring_is_physical_engine(int fd, unsigned int ring);
 bool gem_ring_has_physical_engine(int fd, unsigned int ring);
 
 bool gem_can_store_dword(int fd, unsigned int engine);
+bool gem_class_can_store_dword(int fd, int class);
 
 extern const struct intel_execution_engine2 {
 	const char *name;
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-04-12  0:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-12  0:32 [igt-dev] [PATCH v20 0/6] new engine discovery interface Andi Shyti
2019-04-12  0:32 ` [igt-dev] [PATCH v20 1/6] include/drm-uapi: import i915_drm.h header file Andi Shyti
2019-04-12  0:32 ` [igt-dev] [PATCH v20 2/6] lib/i915: add gem_engine_topology library and for_each loop definition Andi Shyti
2019-04-12  8:16   ` Chris Wilson
2019-04-12 15:32     ` Andi Shyti
2019-04-12 16:31       ` Chris Wilson
2019-04-12  0:32 ` [igt-dev] [PATCH v20 3/6] lib: igt_gt: add eb flags to class helper Andi Shyti
2019-04-12  8:18   ` Chris Wilson
2019-04-12  8:18   ` Chris Wilson
2019-04-12  0:32 ` Andi Shyti [this message]
2019-04-12  0:32 ` [igt-dev] [PATCH v20 5/6] lib: igt_dummyload: use for_each_context_engine() Andi Shyti
2019-04-12  0:32 ` [igt-dev] [PATCH v20 6/6] test: perf_pmu: use the gem_engine_topology library Andi Shyti
2019-04-12 11:34 ` [igt-dev] ✓ Fi.CI.BAT: success for new engine discovery interface Patchwork
2019-04-12 15:22 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190412003210.18762-5-andi@etezian.org \
    --to=andi@etezian.org \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox