Re: [igt-dev] [PATCH v21 5/6] lib: igt_dummyload: use for_each_context_engine()

Tvrtko Ursulin
2019-04-18T08:46:18Z

On 17/04/2019 17:21, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-04-17 17:14:45)
>> So what to do to preserve compatibility with eb.flags and not mess up
>> the context in here.. use the static iterator for contexts wo/ maps and
>> legacy eb? But what does ALL_ENGINES mean then? Phase out ALL_ENGINES
>> support in spin batch? Needs an audit of how many call sites we have and
>> how do they look.
>
> Actually, we've^I've open-coded several callsite that could do with
> ALL_ENGINES. And I think that's a good thing -- as the setup requires a
> bit of finesse and resubmitting the spin batch works quite well. No
> doubt someone else will be tempted to refactor.

I didn't quite get if you want more usages of spin_batch(ALL_ENGINES) or
fewer in the future?

Do we agree that for now at least we don't want to silently modify the
context, and so for now to go with dual paths in the spin batch
constructor, so Andi has a way forward?

Regards,

Tvrtko