Re: [igt-dev] [PATCH v21 5/6] lib: igt_dummyload: use for_each_context_engine()

Chris Wilson
2019-04-17T16:40:44Z

Quoting Tvrtko Ursulin (2019-04-17 17:14:45)
> So what to do to preserve compatibility with eb.flags and not mess up
> the context in here.. use the static iterator for contexts wo/ maps and
> legacy eb? But what does ALL_ENGINES mean then? Phase out ALL_ENGINES
> support in spin batch? Needs an audit of how many call sites we have and
> how do they look.

Actually, we've^I've open-coded several callsite that could do with
ALL_ENGINES. And I think that's a good thing -- as the setup requires a
bit of finesse and resubmitting the spin batch works quite well. No
doubt someone else will be tempted to refactor.
-Chris