Re: [igt-dev] [PATCH v21 2/6] lib/i915: add gem_engine_topology library and for_each loop definition

Andi Shyti
2019-04-16T15:28:29Z

> > +void gem_unset_context_engines(int fd, uint32_t ctx)
> > +{
> > + gem_context_destroy(fd, ctx);
> > +}
>
> That's a little surprising. I certainly would not expect my context to
> be destroyed just to reset the engines back to default.
>
> On the Rusty scale that would be
> -7. The obvious use is wrong.

if I have a context creator 'gem_make_context_set_all_engines()'
(which you already didn't like at the previous version), I should
have a context destroyer.

I understand your concern, I will remove the context creation and
destruction from gem_engine_topology.

Andi