Re: [igt-dev] [PATCH i-g-t v2 8/8] Gitlab CI: Do builds with -Db_ndebug=true

Daniel Vetter
2019-04-17T11:47:54Z

On Tue, Apr 16, 2019 at 07:25:48PM -0400, Lyude wrote:
> From: Lyude Paul <lyude@redhat.com>
>
> To make sure that no one ever uses assert() in the wrong places again,
> let's build with -Db_ndebug=true so that assert() gets compiled out.

Hm, that doesn't catch if someone adds a bogus assert. 2nd build target
for a pure release build too much overkill? meson is quick generally, and
if distros start using this I think it'd make sense.
-Daniel

>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> ---
> .gitlab-ci.yml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index ae8cbb67..0cc134ae 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -10,6 +10,7 @@ variables:
> -Dbuild_tests=true
> -Dbuild_runner=true
> -Dwith_libunwind=true
> + -Db_ndebug=true
> LANG: "C.UTF-8"
>
> stages:
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

--
Daniel Vetter
Software Engineer, Intel Corporation