From: Petri Latvala <petri.latvala@intel.com>
To: Lyude <lyude@redhat.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 5/7] Use pkgconfig() macros with dnf in Fedora Dockerfile
Date: Wed, 17 Apr 2019 12:09:02 +0300 [thread overview]
Message-ID: <20190417090902.GS22949@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20190416201101.9132-6-lyude@redhat.com>
On Tue, Apr 16, 2019 at 04:10:59PM -0400, Lyude wrote:
> From: Lyude Paul <lyude@redhat.com>
>
> dnf supports installing packages by their pkgconfig names using the
> pkgconfig() RPM macro. Since these more closely match the dependencies
> that meson uses and don't have a chance of changing in the future like
> Fedora package name do, let's use these with dnf instead.
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
Do you have a gitlab fork with this patch where gitlab CI can prove
there aren't any typos?
> ---
> Dockerfile.fedora | 48 +++++++++++++++++++++++------------------------
> 1 file changed, 23 insertions(+), 25 deletions(-)
>
> diff --git a/Dockerfile.fedora b/Dockerfile.fedora
> index 29520f7b..469e74b2 100644
> --- a/Dockerfile.fedora
> +++ b/Dockerfile.fedora
> @@ -1,30 +1,28 @@
> FROM fedora:28
>
> -RUN dnf install -y gcc \
> - flex \
> - meson \
> - bison \
> - gtk-doc \
> - xdotool \
> - gsl-devel \
> - kmod-devel \
> - glib2-devel \
> - cairo-devel \
> - ninja-build \
> - procps-devel \
> - pixman-devel \
> - json-c-devel \
> - libdrm-devel \
> - libudev-devel \
> - xmlrpc-c-devel \
> - elfutils-devel \
> - libunwind-devel \
> - python-docutils \
> - libpciaccess-devel \
> - alsa-lib-devel \
> - valgrind-devel \
> - libXrandr-devel \
> - libXv-devel
> +RUN dnf install -y \
> + gcc flex bison meson ninja-build xdotool \
> + 'pkgconfig(libdrm)' \
> + 'pkgconfig(pciaccess)' \
> + 'pkgconfig(libkmod)' \
> + 'pkgconfig(libprocps)' \
> + 'pkgconfig(libunwind)' \
> + 'pkgconfig(libdw)' \
> + 'pkgconfig(pixman-1)' \
> + 'pkgconfig(valgrind)' \
> + 'pkgconfig(cairo)' \
> + 'pkgconfig(libudev)' \
> + 'pkgconfig(glib-2.0)' \
> + 'pkgconfig(gsl)' \
> + 'pkgconfig(alsa)' \
> + 'pkgconfig(xmlrpc)' \
> + 'pkgconfig(xmlrpc_util)' \
> + 'pkgconfig(xmlrpc_client)' \
> + 'pkgconfig(json-c)' \
> + 'pkgconfig(gtk-doc)' \
> + 'pkgconfig(xv)' \
> + 'pkgconfig(xrandr)' \
> + python3-docutils
>
> # We need peg to build overlay
> RUN dnf install -y make
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-04-17 9:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 20:10 [igt-dev] [PATCH i-g-t 0/7] Fixes from updating igt packaging in Fedora Lyude
2019-04-16 20:10 ` [igt-dev] [PATCH i-g-t 1/7] lib/tests: Fix test failures with meson 0.50.0 Lyude
2019-04-17 8:29 ` Petri Latvala
2019-04-16 20:10 ` [igt-dev] [PATCH i-g-t 2/7] meson: Don't redefine gettid if the C library provides it Lyude
2019-04-17 8:37 ` Petri Latvala
2019-04-16 20:10 ` [igt-dev] [PATCH i-g-t 3/7] lib: Stop using assert() for runtime checks Lyude
2019-04-17 8:52 ` Petri Latvala
2019-04-24 0:36 ` Lyude Paul
2019-04-24 10:13 ` Petri Latvala
2019-04-16 20:10 ` [igt-dev] [PATCH i-g-t 4/7] lib/igt_core: Just use igt_can_fail() in __igt_run_subtest() Lyude
2019-04-17 9:05 ` Petri Latvala
2019-04-16 20:10 ` [igt-dev] [PATCH i-g-t 5/7] Use pkgconfig() macros with dnf in Fedora Dockerfile Lyude
2019-04-17 9:09 ` Petri Latvala [this message]
2019-04-24 17:18 ` Lyude Paul
2019-04-16 20:11 ` [igt-dev] [PATCH i-g-t 6/7] Update Dockerfile.fedora to Fedora 29 Lyude
2019-04-16 20:11 ` [igt-dev] [PATCH i-g-t 7/7] Gitlab CI: Do builds with -Db_ndebug=true Lyude
2019-04-16 20:44 ` [igt-dev] ✓ Fi.CI.BAT: success for Fixes from updating igt packaging in Fedora Patchwork
2019-04-17 6:04 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190417090902.GS22949@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=lyude@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox