From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: IGT dev <igt-dev@lists.freedesktop.org>, Andi Shyti <andi@etezian.org>
Subject: Re: [igt-dev] [PATCH v22 4/6] lib: igt_gt: make gem_engine_can_store_dword() check engine class
Date: Wed, 17 Apr 2019 12:42:40 +0300 [thread overview]
Message-ID: <20190417094240.GC2591@intel.intel> (raw)
In-Reply-To: <155549040125.2264.15754424833942696683@skylake-alporthouse-com>
> > Engines referred by class and instance are getting more populare,
> > gem_engine_can_store_dword() should handle the situation.
> >
> > Suggested-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > Signed-off-by: Andi Shyti <andi.shyti@intel.com>
> > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> I would suggest we should
> s/gem_can_store_dword/gem_engine_can_store_dword/
sure, but this has to be a different patch, gem_can_store_dword
is used by too many tests.
> (and move it out of
> igt_gt.c, we are gradually making that i915/)
> and call this gem_engine_class_can_store_dword()
You want to move it to engine_topology? is it pertinent? Or do we
want to start a new gem_igt_gt?
Andi
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-04-17 9:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 23:10 [igt-dev] [PATCH v22 0/6] new engine discovery interface Andi Shyti
2019-04-16 23:10 ` [igt-dev] [PATCH v22 1/6] include/drm-uapi: import i915_drm.h header file Andi Shyti
2019-04-16 23:10 ` [igt-dev] [PATCH v22 2/6] lib/i915: add gem_engine_topology library and for_each loop definition Andi Shyti
2019-04-16 23:10 ` [igt-dev] [PATCH v22 3/6] lib: igt_gt: add execution buffer flags to class helper Andi Shyti
2019-04-17 8:38 ` Chris Wilson
2019-04-16 23:10 ` [igt-dev] [PATCH v22 4/6] lib: igt_gt: make gem_engine_can_store_dword() check engine class Andi Shyti
2019-04-17 8:40 ` Chris Wilson
2019-04-17 9:42 ` Andi Shyti [this message]
2019-04-16 23:10 ` [igt-dev] [PATCH v22 5/6] lib: igt_dummyload: use for_each_context_engine() Andi Shyti
2019-04-16 23:10 ` [igt-dev] [PATCH v22 6/6] test: perf_pmu: use the gem_engine_topology library Andi Shyti
2019-04-17 0:26 ` [igt-dev] ✓ Fi.CI.BAT: success for new engine discovery interface Patchwork
2019-04-17 8:41 ` [igt-dev] [PATCH v22 0/6] " Chris Wilson
2019-04-17 9:17 ` Andi Shyti
2019-04-17 9:50 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190417094240.GC2591@intel.intel \
--to=andi.shyti@intel.com \
--cc=andi@etezian.org \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox