From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 53C346E112 for ; Thu, 18 Apr 2019 11:52:32 +0000 (UTC) Date: Thu, 18 Apr 2019 14:52:28 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Message-ID: <20190418115228.GJ1747@intel.com> References: <20190417203544.22298-1-ville.syrjala@linux.intel.com> <20190417203544.22298-3-ville.syrjala@linux.intel.com> <155553396437.25904.18248707527239086873@skylake-alporthouse-com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <155553396437.25904.18248707527239086873@skylake-alporthouse-com> Subject: Re: [igt-dev] [PATCH i-g-t 3/5] lib/intel_batchbuffer: Make blitter asserts more useful List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson Cc: igt-dev@lists.freedesktop.org List-ID: T24gV2VkLCBBcHIgMTcsIDIwMTkgYXQgMDk6NDY6MDRQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgVmlsbGUgU3lyamFsYSAoMjAxOS0wNC0xNyAyMTozNTo0MikKPiA+IEZy b206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAK PiA+IFVzZSBpZ3RfYXNzZXJ0X2x0L2x0ZSBmb3IgdGhlIGJsaXR0ZXIgY29vcmQvc3RyaWRlIGFz c2VydHMKPiA+IHNvIHRoYXQgd2UgY2FuIHNlZSB3aGF0IHRoZSBvZmZlbmRpbmcgdmFsdWUgd2Fz LiBnY2MgbGlrZXMKPiA+IHRvIG9wdGltaXplIHRoZSB2YWx1ZXMgYXdheSBzbyBnZGIgb2Z0ZW4g ZG9lc24ndCBoZWxwIGFzCj4gPiBtdWNoIGFzIG9uZSB3b3VsZCBsaWtlLgo+ID4gCj4gPiBTaWdu ZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t Pgo+ID4gLS0tCj4gPiAgbGliL2ludGVsX2JhdGNoYnVmZmVyLmMgfCA1NCArKysrKysrKysrKysr KysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAzMCBpbnNl cnRpb25zKCspLCAyNCBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2xpYi9pbnRl bF9iYXRjaGJ1ZmZlci5jIGIvbGliL2ludGVsX2JhdGNoYnVmZmVyLmMKPiA+IGluZGV4IDcxMmNl MWEzMmRhNi4uNDIyZjNiNjE4NmFhIDEwMDY0NAo+ID4gLS0tIGEvbGliL2ludGVsX2JhdGNoYnVm ZmVyLmMKPiA+ICsrKyBiL2xpYi9pbnRlbF9iYXRjaGJ1ZmZlci5jCj4gPiBAQCAtNDE3LDE2ICs0 MTcsMTYgQEAgaW50ZWxfYmx0X2NvcHkoc3RydWN0IGludGVsX2JhdGNoYnVmZmVyICpiYXRjaCwK PiA+ICAgICAgICAgICAgICAgICBjbWRfYml0cyB8PSBYWV9TUkNfQ09QWV9CTFRfRFNUX1RJTEVE Owo+ID4gICAgICAgICB9Cj4gPiAgCj4gPiAtI2RlZmluZSBDSEVDS19SQU5HRSh4KSAoKHgpID49 IDAgJiYgKHgpIDwgKDEgPDwgMTUpKQo+ID4gLSAgICAgICBpZ3RfYXNzZXJ0KENIRUNLX1JBTkdF KHNyY194MSkgJiYgQ0hFQ0tfUkFOR0Uoc3JjX3kxKSAmJgo+ID4gLSAgICAgICAgICAgICAgICAg IENIRUNLX1JBTkdFKGRzdF94MSkgJiYgQ0hFQ0tfUkFOR0UoZHN0X3kxKSAmJgo+ID4gLSAgICAg ICAgICAgICAgICAgIENIRUNLX1JBTkdFKHdpZHRoKSAmJiBDSEVDS19SQU5HRShoZWlnaHQpICYm Cj4gPiAtICAgICAgICAgICAgICAgICAgQ0hFQ0tfUkFOR0Uoc3JjX3gxICsgd2lkdGgpICYmCj4g PiAtICAgICAgICAgICAgICAgICAgQ0hFQ0tfUkFOR0Uoc3JjX3kxICsgaGVpZ2h0KSAmJgo+ID4g LSAgICAgICAgICAgICAgICAgIENIRUNLX1JBTkdFKGRzdF94MSArIHdpZHRoKSAmJgo+ID4gLSAg ICAgICAgICAgICAgICAgIENIRUNLX1JBTkdFKGRzdF95MSArIGhlaWdodCkgJiYKPiA+IC0gICAg ICAgICAgICAgICAgICBDSEVDS19SQU5HRShzcmNfcGl0Y2gpICYmCj4gPiAtICAgICAgICAgICAg ICAgICAgQ0hFQ0tfUkFOR0UoZHN0X3BpdGNoKSk7Cj4gPiArI2RlZmluZSBDSEVDS19SQU5HRSh4 KSBkbyB7IFwKPiA+ICsgICAgICAgaWd0X2Fzc2VydF9sdGUoMCwgKHgpKTsgXAo+ID4gKyAgICAg ICBpZ3RfYXNzZXJ0X2x0KCh4KSwgKDEgPDwgMTUpKTsgXAo+ID4gK30gd2hpbGUgKDApCj4gPiAr ICAgICAgIENIRUNLX1JBTkdFKHNyY194MSk7IENIRUNLX1JBTkdFKHNyY195MSk7Cj4gPiArICAg ICAgIENIRUNLX1JBTkdFKGRzdF94MSk7IENIRUNLX1JBTkdFKGRzdF95MSk7Cj4gPiArICAgICAg IENIRUNLX1JBTkdFKHdpZHRoKTsgQ0hFQ0tfUkFOR0UoaGVpZ2h0KTsKPiA+ICsgICAgICAgQ0hF Q0tfUkFOR0Uoc3JjX3gxICsgd2lkdGgpOyBDSEVDS19SQU5HRShzcmNfeTEgKyBoZWlnaHQpOwo+ ID4gKyAgICAgICBDSEVDS19SQU5HRShkc3RfeDEgKyB3aWR0aCk7IENIRUNLX1JBTkdFKGRzdF95 MSArIGhlaWdodCk7Cj4gPiArICAgICAgIENIRUNLX1JBTkdFKHNyY19waXRjaCk7IENIRUNLX1JB TkdFKGRzdF9waXRjaCk7Cj4gPiAgI3VuZGVmIENIRUNLX1JBTkdFCj4gCj4gT2suCj4gCj4gPiAg ICAgICAgIGJyMTNfYml0cyA9IDA7Cj4gPiBAQCAtNzE1LDEzICs3MTUsMTYgQEAgdm9pZCBpZ3Rf YmxpdHRlcl9mYXN0X2NvcHlfX3JhdyhpbnQgZmQsCj4gPiAgICAgICAgIGR3b3JkMCA9IGZhc3Rf Y29weV9kd29yZDAoc3JjX3RpbGluZywgZHN0X3RpbGluZyk7Cj4gPiAgICAgICAgIGR3b3JkMSA9 IGZhc3RfY29weV9kd29yZDEoc3JjX3RpbGluZywgZHN0X3RpbGluZywgYnBwKTsKPiA+ICAKPiA+ IC0jZGVmaW5lIENIRUNLX1JBTkdFKHgpICgoeCkgPj0gMCAmJiAoeCkgPCAoMSA8PCAxNSkpCj4g PiAtICAgICAgIGFzc2VydChDSEVDS19SQU5HRShzcmNfeCkgJiYgQ0hFQ0tfUkFOR0Uoc3JjX3kp ICYmCj4gPiAtICAgICAgICAgICAgICBDSEVDS19SQU5HRShkc3RfeCkgJiYgQ0hFQ0tfUkFOR0Uo ZHN0X3kpICYmCj4gPiAtICAgICAgICAgICAgICBDSEVDS19SQU5HRSh3aWR0aCkgJiYgQ0hFQ0tf UkFOR0UoaGVpZ2h0KSAmJgo+ID4gLSAgICAgICAgICAgICAgQ0hFQ0tfUkFOR0Uoc3JjX3ggKyB3 aWR0aCkgJiYgQ0hFQ0tfUkFOR0Uoc3JjX3kgKyBoZWlnaHQpICYmCj4gPiAtICAgICAgICAgICAg ICBDSEVDS19SQU5HRShkc3RfeCArIHdpZHRoKSAmJiBDSEVDS19SQU5HRShkc3RfeSArIGhlaWdo dCkgJiYKPiA+IC0gICAgICAgICAgICAgIENIRUNLX1JBTkdFKHNyY19waXRjaCkgJiYgQ0hFQ0tf UkFOR0UoZHN0X3BpdGNoKSk7Cj4gCj4gUGxhaW4gYXNzZXJ0IQo+IAo+ID4gKyNkZWZpbmUgQ0hF Q0tfUkFOR0UoeCkgZG8geyBcCj4gPiArICAgICAgIGlndF9hc3NlcnRfbHRlKDAsICh4KSk7IFwK PiA+ICsgICAgICAgaWd0X2Fzc2VydF9sdCgoeCksICgxIDw8IDE1KSk7IFwKPiA+ICt9IHdoaWxl ICgwKQo+IAo+IFRoaXMgbG9va3MgbGlrZSBhIHJlZGVmaW5pdGlvbj8gT2gsIHVuZGVmLgo+IAo+ IE1heWJlIGNhbGwgaXQgQ0hFQ0tfQkxUX1JBTkdFKCk/IENIRUNLX1hZX1JBTkdFKCk/Cj4gCj4g PiArICAgICAgIENIRUNLX1JBTkdFKHNyY194KTsgQ0hFQ0tfUkFOR0Uoc3JjX3kpOwo+ID4gKyAg ICAgICBDSEVDS19SQU5HRShkc3RfeCk7IENIRUNLX1JBTkdFKGRzdF95KTsKPiA+ICsgICAgICAg Q0hFQ0tfUkFOR0Uod2lkdGgpOyBDSEVDS19SQU5HRShoZWlnaHQpOwo+ID4gKyAgICAgICBDSEVD S19SQU5HRShzcmNfeCArIHdpZHRoKTsgQ0hFQ0tfUkFOR0Uoc3JjX3kgKyBoZWlnaHQpOwo+ID4g KyAgICAgICBDSEVDS19SQU5HRShkc3RfeCArIHdpZHRoKTsgQ0hFQ0tfUkFOR0UoZHN0X3kgKyBo ZWlnaHQpOwo+ID4gKyAgICAgICBDSEVDS19SQU5HRShzcmNfcGl0Y2gpOyBDSEVDS19SQU5HRShk c3RfcGl0Y2gpOwo+ID4gICN1bmRlZiBDSEVDS19SQU5HRQo+IAo+IE9rLgo+IAo+ID4gICAgICAg ICBiYXRjaFtpKytdID0gZHdvcmQwOwo+ID4gQEAgLTc5MSwxMyArNzk0LDE2IEBAIHZvaWQgaWd0 X2JsaXR0ZXJfZmFzdF9jb3B5KHN0cnVjdCBpbnRlbF9iYXRjaGJ1ZmZlciAqYmF0Y2gsCj4gPiAg ICAgICAgIGR3b3JkMCA9IGZhc3RfY29weV9kd29yZDAoc3JjLT50aWxpbmcsIGRzdC0+dGlsaW5n KTsKPiA+ICAgICAgICAgZHdvcmQxID0gZmFzdF9jb3B5X2R3b3JkMShzcmMtPnRpbGluZywgZHN0 LT50aWxpbmcsIGRzdC0+YnBwKTsKPiA+ICAKPiA+IC0jZGVmaW5lIENIRUNLX1JBTkdFKHgpICgo eCkgPj0gMCAmJiAoeCkgPCAoMSA8PCAxNSkpCj4gPiAtICAgICAgIGFzc2VydChDSEVDS19SQU5H RShzcmNfeCkgJiYgQ0hFQ0tfUkFOR0Uoc3JjX3kpICYmCj4gPiAtICAgICAgICAgICAgICBDSEVD S19SQU5HRShkc3RfeCkgJiYgQ0hFQ0tfUkFOR0UoZHN0X3kpICYmCj4gPiAtICAgICAgICAgICAg ICBDSEVDS19SQU5HRSh3aWR0aCkgJiYgQ0hFQ0tfUkFOR0UoaGVpZ2h0KSAmJgo+ID4gLSAgICAg ICAgICAgICAgQ0hFQ0tfUkFOR0Uoc3JjX3ggKyB3aWR0aCkgJiYgQ0hFQ0tfUkFOR0Uoc3JjX3kg KyBoZWlnaHQpICYmCj4gPiAtICAgICAgICAgICAgICBDSEVDS19SQU5HRShkc3RfeCArIHdpZHRo KSAmJiBDSEVDS19SQU5HRShkc3RfeSArIGhlaWdodCkgJiYKPiA+IC0gICAgICAgICAgICAgIENI RUNLX1JBTkdFKHNyY19waXRjaCkgJiYgQ0hFQ0tfUkFOR0UoZHN0X3BpdGNoKSk7Cj4gPiArI2Rl ZmluZSBDSEVDS19SQU5HRSh4KSBkbyB7IFwKPiA+ICsgICAgICAgaWd0X2Fzc2VydF9sdGUoMCwg KHgpKTsgXAo+ID4gKyAgICAgICBpZ3RfYXNzZXJ0X2x0KCh4KSwgKDEgPDwgMTUpKTsgXAo+ID4g K30gd2hpbGUgKDApCj4gCj4gVGhpcmQgdGltZSdzIGEgd2lubmVyIQo+IAo+ID4gKyAgICAgICBD SEVDS19SQU5HRShzcmNfeCk7IENIRUNLX1JBTkdFKHNyY195KTsKPiA+ICsgICAgICAgQ0hFQ0tf UkFOR0UoZHN0X3gpOyBDSEVDS19SQU5HRShkc3RfeSk7Cj4gPiArICAgICAgIENIRUNLX1JBTkdF KHdpZHRoKTsgQ0hFQ0tfUkFOR0UoaGVpZ2h0KTsKPiA+ICsgICAgICAgQ0hFQ0tfUkFOR0Uoc3Jj X3ggKyB3aWR0aCk7IENIRUNLX1JBTkdFKHNyY195ICsgaGVpZ2h0KTsKPiA+ICsgICAgICAgQ0hF Q0tfUkFOR0UoZHN0X3ggKyB3aWR0aCk7IENIRUNLX1JBTkdFKGRzdF95ICsgaGVpZ2h0KTsKPiA+ ICsgICAgICAgQ0hFQ0tfUkFOR0Uoc3JjX3BpdGNoKTsgQ0hFQ0tfUkFOR0UoZHN0X3BpdGNoKTsK PiA+ICAjdW5kZWYgQ0hFQ0tfUkFOR0UKPiAKPiBPay4KPiAKPiBLaWxsIHRoZSByZXBlYXRlZCBD SEVDS19SQU5HRSgpIGRlZmluaXRpb25zLgoKU3VyZS4gQ2FuIGRvLgoKPiAKPiBSZXZpZXdlZC1i eTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLUNocmlzCgotLSAK VmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0 LWRldg==