[igt-dev] [PATCH i-g-t v2 2/5] tests/i915/gem_render_copy: Don't leak bos between subtests

Ville Syrjala
2019-04-18T12:11:38Z

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Unref the bos after one subtest is done. The next subtest
will allocate its own bos.

v2: Add scratch_buf_fini() and reverse the onion (Chris)

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/i915/gem_render_copy.c | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/tests/i915/gem_render_copy.c b/tests/i915/gem_render_copy.c
index 8d62a0f43ad8..b5d1f45f0422 100644
--- a/tests/i915/gem_render_copy.c
+++ b/tests/i915/gem_render_copy.c
@@ -459,6 +459,11 @@ static void scratch_buf_init(data_t *data, struct igt_buf *buf,
igt_assert(igt_buf_height(buf) == height);
}

+static void scratch_buf_fini(struct igt_buf *buf)
+{
+ drm_intel_bo_unreference(buf->bo);
+}
+
static void
scratch_buf_check(data_t *data,
struct igt_buf *buf,
@@ -662,6 +667,13 @@ static void test(data_t *data, uint32_t tiling, uint64_t ccs_modifier)

if (ccs_modifier)
scratch_buf_aux_check(data, &ccs);
+
+ scratch_buf_fini(&ref);
+ if (ccs_modifier)
+ scratch_buf_fini(&ccs);
+ scratch_buf_fini(&dst);
+ for (int i = 0; i < num_src; i++)
+ scratch_buf_fini(&src[i].buf);
}

static int opt_handler(int opt, int opt_index, void *data)
--
2.21.0