Re: [igt-dev] [PATCH i-g-t 1/5] lib/igt_fb: Unref the renderecopy scratch bos

Chris Wilson
2019-04-17T20:39:03Z

Quoting Ville Syrjala (2019-04-17 21:35:40)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We're currently leaking all the temporary bos we construct
> for rendercopy. That doesn't go so well when trying to test
> with 1GiB framebuffers.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> lib/igt_fb.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index 6a43fcc4735f..c3ecd7186444 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -1647,6 +1647,9 @@ static void rendercopy(struct fb_blit_upload *blit,
> render_copy(blit->batch, NULL,
> &src, 0, 0, dst_fb->plane_width[0], dst_fb->plane_height[0],
> &dst, 0, 0);
> +
> + drm_intel_bo_unreference(dst.bo);
> + drm_intel_bo_unreference(src.bo);

For symmetry I would suggest a fini_buf().
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris