public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 3/5] lib/rendercopy: Add fp16 support for gen4+
Date: Thu, 18 Apr 2019 22:40:41 +0300	[thread overview]
Message-ID: <20190418194043.5184-3-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20190418194043.5184-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Allow copying between fp16 surfaces. We'll use the FLOAT
surface format since that's all the display supports currently.
Hopefully the hardware gives us a 1:1 copy, at least if
the input doesn't contain crazy infs/nans etc. We could
choose UNORM instead but that won't work for eventually
exposing fp16+ccs. Although we do need to replace the
simple bpp value with a more specific format type to get
10bpc+ccs working as well.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 lib/rendercopy_gen4.c | 1 +
 lib/rendercopy_gen6.c | 1 +
 lib/rendercopy_gen7.c | 1 +
 lib/rendercopy_gen8.c | 1 +
 lib/rendercopy_gen9.c | 1 +
 5 files changed, 5 insertions(+)

diff --git a/lib/rendercopy_gen4.c b/lib/rendercopy_gen4.c
index 9111508f3ec9..42de77f9f878 100644
--- a/lib/rendercopy_gen4.c
+++ b/lib/rendercopy_gen4.c
@@ -160,6 +160,7 @@ gen4_bind_buf(struct intel_batchbuffer *batch,
 		case 8: ss->ss0.surface_format = SURFACEFORMAT_R8_UNORM; break;
 		case 16: ss->ss0.surface_format = SURFACEFORMAT_R8G8_UNORM; break;
 		case 32: ss->ss0.surface_format = SURFACEFORMAT_B8G8R8A8_UNORM; break;
+		case 64: ss->ss0.surface_format = SURFACEFORMAT_R16G16B16A16_FLOAT; break;
 		default: igt_assert(0);
 	}
 
diff --git a/lib/rendercopy_gen6.c b/lib/rendercopy_gen6.c
index a6157cfc70f6..b90466d007f9 100644
--- a/lib/rendercopy_gen6.c
+++ b/lib/rendercopy_gen6.c
@@ -97,6 +97,7 @@ gen6_bind_buf(struct intel_batchbuffer *batch, const struct igt_buf *buf,
 		case 8: ss->ss0.surface_format = SURFACEFORMAT_R8_UNORM; break;
 		case 16: ss->ss0.surface_format = SURFACEFORMAT_R8G8_UNORM; break;
 		case 32: ss->ss0.surface_format = SURFACEFORMAT_B8G8R8A8_UNORM; break;
+		case 64: ss->ss0.surface_format = SURFACEFORMAT_R16G16B16A16_FLOAT; break;
 		default: igt_assert(0);
 	}
 
diff --git a/lib/rendercopy_gen7.c b/lib/rendercopy_gen7.c
index 0a5d4a151e0d..949468427b2f 100644
--- a/lib/rendercopy_gen7.c
+++ b/lib/rendercopy_gen7.c
@@ -73,6 +73,7 @@ gen7_bind_buf(struct intel_batchbuffer *batch,
 		case 8: format = SURFACEFORMAT_R8_UNORM; break;
 		case 16: format = SURFACEFORMAT_R8G8_UNORM; break;
 		case 32: format = SURFACEFORMAT_B8G8R8A8_UNORM; break;
+		case 64: format = SURFACEFORMAT_R16G16B16A16_FLOAT; break;
 		default: igt_assert(0);
 	}
 
diff --git a/lib/rendercopy_gen8.c b/lib/rendercopy_gen8.c
index 643b6630d4a3..f7a33947166e 100644
--- a/lib/rendercopy_gen8.c
+++ b/lib/rendercopy_gen8.c
@@ -170,6 +170,7 @@ gen8_bind_buf(struct intel_batchbuffer *batch,
 		case 8: ss->ss0.surface_format = SURFACEFORMAT_R8_UNORM; break;
 		case 16: ss->ss0.surface_format = SURFACEFORMAT_R8G8_UNORM; break;
 		case 32: ss->ss0.surface_format = SURFACEFORMAT_B8G8R8A8_UNORM; break;
+		case 64: ss->ss0.surface_format = SURFACEFORMAT_R16G16B16A16_FLOAT; break;
 		default: igt_assert(0);
 	}
 	ss->ss0.render_cache_read_write = 1;
diff --git a/lib/rendercopy_gen9.c b/lib/rendercopy_gen9.c
index 93e9d150e717..5c6485d750a9 100644
--- a/lib/rendercopy_gen9.c
+++ b/lib/rendercopy_gen9.c
@@ -201,6 +201,7 @@ gen8_bind_buf(struct intel_batchbuffer *batch, const struct igt_buf *buf,
 		case 8: ss->ss0.surface_format = SURFACEFORMAT_R8_UNORM; break;
 		case 16: ss->ss0.surface_format = SURFACEFORMAT_R8G8_UNORM; break;
 		case 32: ss->ss0.surface_format = SURFACEFORMAT_B8G8R8A8_UNORM; break;
+		case 64: ss->ss0.surface_format = SURFACEFORMAT_R16G16B16A16_FLOAT; break;
 		default: igt_assert(0);
 	}
 	ss->ss0.render_cache_read_write = 1;
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-04-18 19:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-18 19:40 [igt-dev] [PATCH i-g-t 1/5] lib/igt_fb: Fix the cairo shadow buffer stride Ville Syrjala
2019-04-18 19:40 ` [igt-dev] [PATCH i-g-t 2/5] lib/igt_fb: Fix 32bit integer overflow in the shadow buffer size calculation Ville Syrjala
2019-04-26 19:14   ` Chris Wilson
2019-04-18 19:40 ` Ville Syrjala [this message]
2019-04-26 19:16   ` [igt-dev] [PATCH i-g-t 3/5] lib/rendercopy: Add fp16 support for gen4+ Chris Wilson
2019-04-18 19:40 ` [igt-dev] [PATCH i-g-t 4/5] lib/rendercopy: Configure MOCS more consistently Ville Syrjala
2019-04-26 19:18   ` Chris Wilson
2019-04-26 19:27     ` Ville Syrjälä
2019-04-18 19:40 ` [igt-dev] [PATCH i-g-t 5/5] tests/kms_big_fb: Make sure huge fbs work correctly Ville Syrjala
2019-04-26 16:50   ` [igt-dev] [PATCH i-g-t v2 " Ville Syrjala
2019-04-18 20:34 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/5] lib/igt_fb: Fix the cairo shadow buffer stride Patchwork
2019-04-18 22:46 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-04-26 17:59 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/5] lib/igt_fb: Fix the cairo shadow buffer stride (rev2) Patchwork
2019-04-26 19:14 ` [igt-dev] [PATCH i-g-t 1/5] lib/igt_fb: Fix the cairo shadow buffer stride Chris Wilson
2019-04-26 23:41 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/5] lib/igt_fb: Fix the cairo shadow buffer stride (rev2) Patchwork
2019-04-29 10:24   ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190418194043.5184-3-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox