Re: [igt-dev] [PATCH i-g-t] audio: Avoid test_integrity failing if there's no HW support

Chris Wilson
2019-04-23T12:00:46Z

Quoting Ser, Simon (2019-04-23 12:45:05)
> On Tue, 2019-04-23 at 09:09 +0100, Chris Wilson wrote:
> > Before asserting that the HDMI audio loopback works after resume, first
> > require it to be present before suspend -- as not all machines are setup
> > with the right HDMI audio capture.
> >
> > More strictly, one would expect that an audio capture device setup
> > before suspend will remain functional after resume. An exercise left for
> > the reader.
>
> What if audio works without suspend, but breaks with suspend? That new
> test makes it less easy to understand whether audio works at all or if
> it breaks because of suspend.

That's the test; whether audio continues to work across suspend. It's
the original test, not a new one.

What the igt didn't (and still doesn't) do correctly is verify it has a
working setup; for now we just assume that the driver is fine if igt_alsa
fails. Turns a broken test from "DRIVER FAIL" to skip.
-Chris