Re: [igt-dev] [PATCH i-g-t v7 0/8] tests/kms_chamelium: add dp-audio test

Martin Peres
2019-04-25T10:00:04Z

On 23/04/2019 16:04, Simon Ser wrote:
> Changes in v7: addressed Martin's comments
>
> Thanks for the detailed review! I've tried splitting some commits, let me know
> if more splitting is needed.

Thanks for the changes! The series is (excluding the HAX patch):

Reviewed-by: Martin Peres <martin.peres@linux.intel.com>

>
> Simon Ser (8):
> tests/kms_chamelium: add dp-audio test
> tests/kms_chamelium: capture audio data in real-time
> lib/igt_{alsa,audio}: improve logging
> lib/igt_alsa: use variables to improve readability
> tests/kms_chamelium: test we receive a signal from both audio channels
> tests/kms_chamelium: test audio channels are not mixed up
> tests/kms_chamelium: run audio test with multiple sampling rates
> HAX: add dp-audio test to fast-feedback
>
> docs/audio.txt | 45 --
> docs/chamelium.txt | 34 +-
> lib/igt.h | 1 +
> lib/igt_alsa.c | 83 +++-
> lib/igt_alsa.h | 1 +
> lib/igt_audio.c | 428 +++++++++++++------
> lib/igt_audio.h | 19 +-
> lib/igt_aux.c | 31 ++
> lib/igt_aux.h | 1 +
> lib/igt_chamelium.c | 161 ++++++++
> lib/igt_chamelium.h | 17 +
> lib/igt_chamelium_stream.c | 572 ++++++++++++++++++++++++++
> lib/igt_chamelium_stream.h | 50 +++
> lib/meson.build | 5 +-
> meson.build | 52 +--
> meson_options.txt | 6 -
> tests/audio.c | 193 ---------
> tests/intel-ci/fast-feedback.testlist | 1 +
> tests/kms_chamelium.c | 355 +++++++++++++++-
> tests/meson.build | 9 +-
> 20 files changed, 1614 insertions(+), 450 deletions(-)
> delete mode 100644 docs/audio.txt
> create mode 100644 lib/igt_chamelium_stream.c
> create mode 100644 lib/igt_chamelium_stream.h
> delete mode 100644 tests/audio.c
>