From: Simon Ser <simon.ser@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] lib/igt_halffloat: fix compilation with Clang
Date: Wed, 24 Apr 2019 10:01:29 +0300 [thread overview]
Message-ID: <20190424070129.8591-1-simon.ser@intel.com> (raw)
The source file contains a special code-path for Clang, however this path fails
to compile:
../lib/igt_halffloat.c:227:7: error: conflicting types for 'igt_half_to_float'
float igt_half_to_float(const uint16_t *h, float *f, unsigned int num)
^
../lib/igt_halffloat.h:26:6: note: previous declaration is here
void igt_half_to_float(const uint16_t *h, float *f, unsigned int num);
^
1 error generated.
This commit fixes this mismatch.
Signed-off-by: Simon Ser <simon.ser@intel.com>
---
lib/igt_halffloat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/igt_halffloat.c b/lib/igt_halffloat.c
index 263b28c1..08ab05fc 100644
--- a/lib/igt_halffloat.c
+++ b/lib/igt_halffloat.c
@@ -224,7 +224,7 @@ void igt_float_to_half(const float *f, uint16_t *h, unsigned int num)
h[i] = _float_to_half(f[i]);
}
-float igt_half_to_float(const uint16_t *h, float *f, unsigned int num)
+void igt_half_to_float(const uint16_t *h, float *f, unsigned int num)
{
for (int i = 0; i < num; i++)
f[i] = _half_to_float(h[i]);
--
2.21.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2019-04-24 7:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 7:01 Simon Ser [this message]
2019-04-24 8:03 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_halffloat: fix compilation with Clang Patchwork
2019-04-24 9:28 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2019-04-24 13:26 ` Petri Latvala
2019-04-24 20:06 ` Daniel Vetter
2019-04-25 7:36 ` Daniel Vetter
2019-04-25 11:28 ` Ser, Simon
2019-04-24 13:18 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424070129.8591-1-simon.ser@intel.com \
--to=simon.ser@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox