From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6AE3B891D2 for ; Wed, 24 Apr 2019 10:13:46 +0000 (UTC) Date: Wed, 24 Apr 2019 13:13:43 +0300 From: Petri Latvala Message-ID: <20190424101343.GW22949@platvala-desk.ger.corp.intel.com> References: <20190416201101.9132-1-lyude@redhat.com> <20190416201101.9132-4-lyude@redhat.com> <20190417085216.GQ22949@platvala-desk.ger.corp.intel.com> <9670ac4a8a56283aeaf71bc873d0cc63dc38df20.camel@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9670ac4a8a56283aeaf71bc873d0cc63dc38df20.camel@redhat.com> Subject: Re: [igt-dev] [PATCH i-g-t 3/7] lib: Stop using assert() for runtime checks List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Lyude Paul Cc: igt-dev@lists.freedesktop.org List-ID: T24gVHVlLCBBcHIgMjMsIDIwMTkgYXQgMDg6MzY6NDNQTSAtMDQwMCwgTHl1ZGUgUGF1bCB3cm90 ZToKPiBPbiBXZWQsIDIwMTktMDQtMTcgYXQgMTE6NTIgKzAzMDAsIFBldHJpIExhdHZhbGEgd3Jv dGU6Cj4gPiBPbiBUdWUsIEFwciAxNiwgMjAxOSBhdCAwNDoxMDo1N1BNIC0wNDAwLCBMeXVkZSB3 cm90ZToKPiA+ID4gRnJvbTogTHl1ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNvbT4KPiA+ID4gCj4g PiA+IEluIHRoZSBwcm9jZXNzIG9mIHRyeWluZyB0byBnZXQgYW4gdXAgdG8gZGF0ZSB2ZXJzaW9u IG9mIGlndCBwYWNrYWdlZAo+ID4gPiBmb3IgRmVkb3JhIEkgZGlzY292ZXJlZCB0aGF0IGlmIGln dCB3YXMgYnVpbHQgd2l0aCAtRGJfbmRlYnVnPXRydWUsIGEKPiA+ID4gc2lnbmlmaWNhbnQgcG9y dGlvbiBvZiB0aGUgdGVzdCBpbmZyYXN0cnVjdHVyZSB1bml0IHRlc3RzIHdvdWxkIHN0YXJ0Cj4g PiA+IGZhaWxpbmc6Cj4gPiA+IAo+ID4gPiAgIDEvMjY1IGxpYjogaWd0X2Fzc2VydCAgICAgICAg ICAgICAgICAgICAgICAgICBPSyAgICAgICAwLjExIHMKPiA+ID4gICAyLzI2NSBsaWI6IGlndF9j YW5fZmFpbCAgICAgICAgICAgICAgICAgICAgICAgT0sgICAgICAgMC4wOCBzCj4gPiA+ICAgMy8y NjUgbGliOiBpZ3RfY2FuX2ZhaWxfc2ltcGxlICAgICAgICAgICAgICAgIE9LICAgICAgIDAuMDgg cwo+ID4gPiAgIDQvMjY1IGxpYjogaWd0X2V4aXRfaGFuZGxlciAgICAgICAgICAgICAgICAgICBP SyAgICAgICAwLjA1IHMKPiA+ID4gICA1LzI2NSBsaWI6IGlndF9mb3JrICAgICAgICAgICAgICAg ICAgICAgICAgICAgRkFJTCAgICAgMC4wNSBzIChraWxsZWQgYnkKPiA+ID4gc2lnbmFsIDkgU0lH S0lMTCkKPiA+ID4gICA2LzI2NSBsaWI6IGlndF9mb3JrX2hlbHBlciAgICAgICAgICAgICAgICAg ICAgT0sgICAgICAgMC40MiBzCj4gPiA+ICAgNy8yNjUgbGliOiBpZ3RfaGRtaV9pbmplY3QgICAg ICAgICAgICAgICAgICAgIE9LICAgICAgIDAuMDUgcwo+ID4gPiAgIDgvMjY1IGxpYjogaWd0X2xp c3Rfb25seSAgICAgICAgICAgICAgICAgICAgICBPSyAgICAgICAwLjAxIHMKPiA+ID4gICA5LzI2 NSBsaWI6IGlndF9pbnZhbGlkX3N1YnRlc3RfbmFtZSAgICAgICAgICAgT0sgICAgICAgMC4wNSBz Cj4gPiA+ICAxMC8yNjUgbGliOiBpZ3Rfbm9fZXhpdCAgICAgICAgICAgICAgICAgICAgICAgIE9L ICAgICAgIDAuMDQgcwo+ID4gPiAgMTEvMjY1IGxpYjogaWd0X3NlZ2ZhdWx0ICAgICAgICAgICAg ICAgICAgICAgICBPSyAgICAgICAwLjM4IHMKPiA+ID4gIDEyLzI2NSBsaWI6IGlndF9zaW11bGF0 aW9uICAgICAgICAgICAgICAgICAgICAgT0sgICAgICAgMC4wMiBzCj4gPiA+ICAxMy8yNjUgbGli OiBpZ3Rfc3RhdHMgICAgICAgICAgICAgICAgICAgICAgICAgIE9LICAgICAgIDAuMDQgcwo+ID4g PiAgMTQvMjY1IGxpYjogaWd0X3N1YnRlc3RfZ3JvdXAgICAgICAgICAgICAgICAgICBPSyAgICAg ICAwLjAzIHMKPiA+ID4gIDE1LzI2NSBsaWI6IGlndF9ub19zdWJ0ZXN0ICAgICAgICAgICAgICAg ICAgICAgU0tJUCAgICAgMC4wMiBzCj4gPiA+ICAxNi8yNjUgbGliOiBpZ3Rfc2ltcGxlX3Rlc3Rf c3VidGVzdHMgICAgICAgICAgIFVORVhQRUNURURQQVNTIDAuMDIgcwo+ID4gPiAgMTcvMjY1IGxp YjogaWd0X3RpbWVvdXQgICAgICAgICAgICAgICAgICAgICAgICBFWFBFQ1RFREZBSUwgMS4wMiBz Cj4gPiA+IAo+ID4gPiBXaGljaCBhcHBlYXJlZCB0byBzdGVtIGZyb20gdGhlIGZhY3QgdGhhdCAt RGJfbmRlYnVnPXRydWUgd291bGQgc3RyaXAKPiA+ID4gYXNzZXJ0KCkgY2FsbHMuIFdoaWxlIG9u IGEgZmlyc3QgZ2xhbmNlIG9mIGxpYi90ZXN0cy9pZ3RfdGVzdHNfY29tbW9uLmgKPiA+ID4gb25l IHdvdWxkIGFzc3VtZSB0aGF0IHRoZSBvbmx5IHVzZXIgb2YgYXNzZXJ0KCkgd2FzIHRoZSB0ZXN0 Cj4gPiA+IGluZnJhc3RydWN0dXJlIHVuaXQgdGVzdHMgdGhlbXNlbHZlcywgaXQgdHVybnMgb3V0 IHdlJ3ZlIGFjdHVhbGx5IGJlZW4KPiA+ID4gdXNpbmcgdGhpcyBpbiBtdWx0aXBsZSBzcG90cyB0 aGF0IHNlZW0gdG8gZXhwZWN0IGFuIHVuY29uZGl0aW9uYWwKPiA+ID4gcnVudGltZSBjaGVjay4K PiA+IAo+ID4gVW1tLCB5ZXMuIFlvdSd2ZSB1bmNvdmVyZWQgYSBidWcsIGJ1dCBub3Qgd2hhdCB5 b3UgdGhpbmsuIFdpdGggbWVzb24sCj4gPiB3ZSBkb24ndCBpbmNsdWRlIGxpYi9jaGVjay1uZGVi dWcuaCBhbnltb3JlLCBvbmx5IHdpdGggYXV0b3Rvb2xzIHNvCj4gPiB5b3UgbWlzc2VkIHRoZSBp bXBvcnRhbnQgcGFydDogRG8gbm90IGF0dGVtcHQgdG8gYnVpbGQgSUdUIHdpdGgKPiA+IGJfbmRl YnVnPXRydWUuCj4gCj4gSWYgaWd0IHJlYWxseSBpc24ndCBzdXBwb3NlZCB0byBiZSBidWlsdCB3 aXRoIC1EYl9uZGVidWc9dHJ1ZSB3ZSByZWFsbHkgc2hvdWxkCj4gYWRkIGV4cGxpY2l0IGNoZWNr cyBmb3IgdGhpcyBpbiBvdXIgbWVzb24uYnVpbGQgZmlsZSwgZS5nLgo+ICAKPiBpZiBnZXRfb3B0 aW9uKCJiX25kZWJ1ZyIpID09IHRydWUKPiAgICAgZXJyb3IoIkJ1aWxkaW5nIHdpdGggLURiX25k ZWJ1Zz10cnVlIGlzIG5vdCBzdXBwb3J0ZWQiKQo+IGVuZGlmCj4gCj4gRXNwZWNpYWxseSBzaW5j ZSB0aGUgZGVmYXVsdCBpbiBtZXNvbiB1cHN0cmVhbSBpcyBnb2luZyB0byBiZSBjaGFuZ2luZyB0 byBoYXZpbmcKPiAtRGJfbmRlYnVnPXRydWUgb24gcmVsZWFzZSBidWlsZHMgcHJldHR5IHNvb24u IEknbGwgaW5jbHVkZSBhIHBhdGNoIGZvciB0aGlzIGluCj4gdGhlIHYzIHJlc3Bpbi4KClllcCwg YW4gZXhwbGljaXQgY2hlY2sgc291bmRzIGdvb2QuIEFuZCBvdmVycmlkaW5nIHRoZSBkZWZhdWx0 IGluIHRoZQpwcm9qZWN0KCkgY2FsbCBpbiB0b3BsZXZlbCBtZXNvbi5idWlsZC4gQW5kIGhhdmlu ZyBsaWIvY2hlY2stbmRlYnVnLmgKdXNlZCBpbiBtZXNvbiBidWlsZHMgaXMgYSBUT0RPIGl0ZW0g YXMgd2VsbCwgaW4gY2FzZSBwZW9wbGUgaGF2ZSBhCm1hbnVhbCAtRE5ERUJVRyBpbiB0aGVpciBj ZmxhZ3MuCgoKLS0gClBldHJpIExhdHZhbGEKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pZ3QtZGV2