Re: [igt-dev] [PATCH 1/3] lib: Add halffloat implementation

Strasser, Kevin
2019-04-24T20:43:57Z

Ville Syrjälä wrote:
> On Wed, Apr 24, 2019 at 10:05:28PM +0200, Daniel Vetter wrote:
> > On Fri, Apr 05, 2019 at 01:14:03PM -0700, Kevin Strasser wrote:
> > > Probe for and make an API available for tests to use f16c intrinsics
> > > to generate needed fp16 pixel data.
> > >
> > > Also import a pure c fp32 <-> fp16 conversion implementation from
> > > Mesa 18.3.4, which will act as a fallback when f16c is unavailable.
> > >
> > > rfc2:
> > > - Change API to reduce number of function calls (Maarten)
> > >
> > > v1:
> > > - Move pragma so AVX code isn't emitted for fallbacks (Ville)
> > > - Change edx to ecx (Ville)
> > >
> > > Signed-off-by: Kevin Strasser <kevin.strasser@intel.com>
> > > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > btw this broke the build, and someone else got to fix it up for you:
> >
> > commit 11e10bc575516c56978640fcc697c27f277c660a
> > Author: Simon Ser <simon.ser@intel.com>
> > Date: Wed Apr 24 10:01:29 2019 +0300
> >
> > lib/igt_halffloat: fix compilation with Clang
>
> Since when is building with clang a requirement?

I didn't realize clang was a requirement either, but I should've known
better as it does seem to be a pattern across fdo projects.

Thanks for the fix, Simon!

-Kevin