From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: igt-dev@lists.freedesktop.org, Kevin Strasser <kevin.strasser@intel.com>
Subject: Re: [igt-dev] [PATCH 1/3] lib: Add halffloat implementation
Date: Wed, 24 Apr 2019 23:19:06 +0300 [thread overview]
Message-ID: <20190424201906.GI1747@intel.com> (raw)
In-Reply-To: <20190424200528.GV9857@phenom.ffwll.local>
On Wed, Apr 24, 2019 at 10:05:28PM +0200, Daniel Vetter wrote:
> On Fri, Apr 05, 2019 at 01:14:03PM -0700, Kevin Strasser wrote:
> > Probe for and make an API available for tests to use f16c intrinsics to
> > generate needed fp16 pixel data.
> >
> > Also import a pure c fp32 <-> fp16 conversion implementation from Mesa
> > 18.3.4, which will act as a fallback when f16c is unavailable.
> >
> > rfc2:
> > - Change API to reduce number of function calls (Maarten)
> >
> > v1:
> > - Move pragma so AVX code isn't emitted for fallbacks (Ville)
> > - Change edx to ecx (Ville)
> >
> > Signed-off-by: Kevin Strasser <kevin.strasser@intel.com>
> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> btw this broke the build, and someone else got to fix it up for you:
>
> commit 11e10bc575516c56978640fcc697c27f277c660a
> Author: Simon Ser <simon.ser@intel.com>
> Date: Wed Apr 24 10:01:29 2019 +0300
>
> lib/igt_halffloat: fix compilation with Clang
Since when is building with clang a requirement?
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-04-24 20:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 20:14 [igt-dev] [PATCH 0/3] Add support for fp16 formats Kevin Strasser
2019-04-05 20:14 ` [igt-dev] [PATCH 1/3] lib: Add halffloat implementation Kevin Strasser
2019-04-24 20:05 ` Daniel Vetter
2019-04-24 20:19 ` Ville Syrjälä [this message]
2019-04-24 20:43 ` Strasser, Kevin
2019-04-25 7:34 ` Daniel Vetter
2019-04-05 20:14 ` [igt-dev] [PATCH 2/3] lib/igt_fb: Add support for fp16 formats through conversion Kevin Strasser
2019-04-05 20:14 ` [igt-dev] [PATCH 3/3] tests/kms_plane_scaling: Skip testing unsupported fp16 features Kevin Strasser
2019-04-09 8:17 ` Maarten Lankhorst
2019-04-11 22:36 ` Strasser, Kevin
2019-04-18 19:25 ` Ville Syrjälä
2019-04-05 20:35 ` [igt-dev] ✓ Fi.CI.BAT: success for Add support for fp16 formats Patchwork
2019-04-06 18:11 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424201906.GI1747@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=igt-dev@lists.freedesktop.org \
--cc=kevin.strasser@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox