From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [igt-dev] [PATCH i-g-t] ci: build with Clang
Date: Thu, 25 Apr 2019 15:49:49 +0200 [thread overview]
Message-ID: <20190425134949.GB3273@phenom.ffwll.local> (raw)
In-Reply-To: <87a7getn6f.fsf@intel.com>
On Thu, Apr 25, 2019 at 01:05:28PM +0300, Jani Nikula wrote:
> On Thu, 25 Apr 2019, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> >> This adds a build step with Clang on Fedora. Hopefully this can help keeping
> >> Clang builds healthy.
> >>
> >> Signed-off-by: Simon Ser <simon.ser@intel.com>
> >> ---
> >> .gitlab-ci.yml | 8 ++++++++
> >> 1 file changed, 8 insertions(+)
> >>
> >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> >> index ae8cbb67..e7d31376 100644
> >> --- a/.gitlab-ci.yml
> >> +++ b/.gitlab-ci.yml
> >> @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> >> - ninja -C build
> >> - ninja -C build igt-gpu-tools-doc
> >>
> >> +build:tests-fedora-clang:
> >> + stage: build
> >> + script:
> >> + - dnf install -y clang
> >> + - export CC=clang
> >> + - meson $MESON_OPTIONS build
> >> + - ninja -C build
> >
> > Uh why?
> >
> > The thing that broken is building on non-x86 hosts, and that's the thing
> > gitlab CI caught. I have no idea why this is all about clang (imo it's
> > not), and I don't think we should care about clang either.
>
> And why shouldn't we care about clang?
What I meant is: We already have gitlab ci targets that caught the recent
clang regression (because a lot more broke). No one gave a shit from what
I can tell, so I guess I'm questioning the value of more gitlab CI targets
in general. We could fix that by going to merge requests and blocking
pulls that fail to build I guess.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-04-25 13:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 16:15 [igt-dev] [PATCH i-g-t] ci: build with Clang Simon Ser
2019-04-24 18:40 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-25 5:09 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-04-25 7:35 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
2019-04-25 7:36 ` Daniel Vetter
2019-04-25 10:05 ` Jani Nikula
2019-04-25 13:49 ` Daniel Vetter [this message]
2019-04-25 13:54 ` Ser, Simon
2019-04-25 14:08 ` Arkadiusz Hiler
2019-04-25 14:00 ` Arkadiusz Hiler
2019-04-25 14:56 ` Ville Syrjälä
2019-04-30 11:11 ` Arkadiusz Hiler
2019-04-25 11:22 ` Ser, Simon
2019-04-25 11:45 ` Petri Latvala
2019-04-25 13:46 ` Daniel Vetter
2019-04-25 13:50 ` Arkadiusz Hiler
2019-04-30 11:19 ` [igt-dev] [PATCH v2 " Arkadiusz Hiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425134949.GB3273@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox