From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E5296E7B8 for ; Tue, 7 May 2019 11:58:32 +0000 (UTC) Date: Tue, 7 May 2019 14:58:10 +0300 From: Imre Deak Message-ID: <20190507115810.GC22037@ideak-desk.fi.intel.com> References: <20190507085154.32256-1-oleg.vasilev@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190507085154.32256-1-oleg.vasilev@intel.com> Subject: Re: [igt-dev] [PATCH] tests/i915_pm_rpm: improved strictness and verbosity of i2c subtest List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: imre.deak@intel.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Oleg Vasilev , Jani Nikula , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: igt-dev@lists.freedesktop.org List-ID: T24gVHVlLCBNYXkgMDcsIDIwMTkgYXQgMTE6NTE6NTRBTSArMDMwMCwgT2xlZyBWYXNpbGV2IHdy b3RlOgo+IFRlc3QgY2hlY2tlZCB0aGF0IHRoZSBudW1iZXIgb2YgdmFsaWQgZWRpZHMgZnJvbSBk cm0gaXMgZXF1YWwgdG8gdGhlCj4gc2FtZSBudW1iZXIgZnJvbSBpMmMuCj4gCj4gTm93IGZvciBl YWNoIGVkaWQgdGhlIHdob2xlIGJsb2IgaXMgY29tcGFyZWQuIEluIGNhc2Ugb2YgbWlzbWF0Y2gg dGhlCj4gd2hvbGUgZWRpZCBpcyBwcmludGVkLgoKSG0sIGlmIEknbSBwYXJzaW5nIHRoZSBjb2Rl IGNvcnJlY3RseSB3ZSBoYXZlIGEgc3ltbGluayB0byB0aGUKY29ubmVjdG9yJ3MgSTJDIGRldmlj ZSBvbmx5IGZvciBEUCBhbmQgU0RWTyBjb25uZWN0b3JzLCBidXQgbm90IGZvcgpIRE1JIG9yIFZH QS4KCkphbmksIFZpbGxlIGRvIHlvdSBrbm93IHdoYXQncyB0aGUgcmVhc29uIGZvciB0aGF0PyBJ IHRoaW5rIGhhdmluZyBhCnN5bWxpbmsgd291bGQgYmUgdXNlZnVsLgoKSXMgdGhlcmUgYW5vdGhl ciB3YXkgdG8gaWRlbnRpZnkgd2hpY2ggSTJDIGRldmljZSBhIGNvbm5lY3RvciB1c2VzPwoKPiAK PiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA0MDk3Cj4gQ2M6IEFya2FkaXVzeiBIaWxlciA8YXJrYWRpdXN6LmhpbGVyQGludGVsLmNvbT4K PiBDYzogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IE9s ZWcgVmFzaWxldiA8b2xlZy52YXNpbGV2QGludGVsLmNvbT4KPiAtLS0KPiAgdGVzdHMvaTkxNS9p OTE1X3BtX3JwbS5jIHwgMTc2ICsrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0t LQo+ICAxIGZpbGUgY2hhbmdlZCwgMTA4IGluc2VydGlvbnMoKyksIDY4IGRlbGV0aW9ucygtKQo+ IAo+IGRpZmYgLS1naXQgYS90ZXN0cy9pOTE1L2k5MTVfcG1fcnBtLmMgYi90ZXN0cy9pOTE1L2k5 MTVfcG1fcnBtLmMKPiBpbmRleCBhMmM5ZDBlZC4uZjE1MzAzOTEgMTAwNjQ0Cj4gLS0tIGEvdGVz dHMvaTkxNS9pOTE1X3BtX3JwbS5jCj4gKysrIGIvdGVzdHMvaTkxNS9pOTE1X3BtX3JwbS5jCj4g QEAgLTU3MSwzMyArNTcxLDU2IEBAIHN0YXRpYyB2b2lkIGFzc2VydF9kcm1faW5mb3NfZXF1YWwo c3RydWN0IGNvbXBhcmVfZGF0YSAqZDEsCj4gIAkJYXNzZXJ0X2RybV9jcnRjc19lcXVhbChkMS0+ Y3J0Y3NbaV0sIGQyLT5jcnRjc1tpXSk7Cj4gIH0KPiAgCj4gLS8qIFdlIGNvdWxkIGNoZWNrIHRo ZSBjaGVja3N1bSB0b28sIGJ1dCBqdXN0IHRoZSBoZWFkZXIgaXMgcHJvYmFibHkgZW5vdWdoLiAq Lwo+IC1zdGF0aWMgYm9vbCBlZGlkX2lzX3ZhbGlkKGNvbnN0IHVuc2lnbmVkIGNoYXIgKmVkaWQp Cj4gK3N0YXRpYyBib29sIGZpbmRfaTJjX3BhdGgoY2hhciAqY29ubmVjdG9yX25hbWUsIGNoYXIg KmkyY19wYXRoKQo+ICB7Cj4gLQljaGFyIGVkaWRfaGVhZGVyW10gPSB7Cj4gLQkJMHgwLCAweEZG LCAweEZGLCAweEZGLCAweEZGLCAweEZGLCAweEZGLCAweDAsCj4gLQl9Owo+ICsJc3RydWN0IGRp cmVudCAqZGlyZW50Owo+ICsJRElSICpkaXI7Cj4gKwlpbnQgc3lzZnNfY2FyZF9mZCA9IGlndF9z eXNmc19vcGVuKGRybV9mZCk7Cj4gKwlpbnQgY29ubmVjdG9yX2ZkID0gLTE7Cj4gKwlib29sIGZv dW5kX2kyY19maWxlID0gZmFsc2U7Cj4gIAo+IC0JcmV0dXJuIChtZW1jbXAoZWRpZCwgZWRpZF9o ZWFkZXIsIHNpemVvZihlZGlkX2hlYWRlcikpID09IDApOwo+IC19Cj4gKwlkaXIgPSBmZG9wZW5k aXIoc3lzZnNfY2FyZF9mZCk7Cj4gKwlpZ3RfYXNzZXJ0KGRpcik7Cj4gIAo+IC1zdGF0aWMgaW50 IGNvdW50X2RybV92YWxpZF9lZGlkcyhzdHJ1Y3QgbW9kZV9zZXRfZGF0YSAqZGF0YSkKPiAtewo+ IC0JaW50IHJldCA9IDA7Cj4gKwl3aGlsZSAoKGRpcmVudCA9IHJlYWRkaXIoZGlyKSkpIHsKPiAr CQkvKiBTa2lwICJjYXJkeC0iIHByZWZpeCAqLwo+ICsJCWNoYXIgKmRpcm5hbWUgPSBkaXJlbnQt PmRfbmFtZTsKPiArCQl3aGlsZShkaXJuYW1lWzBdICE9ICdcMCcgJiYgZGlybmFtZVswXSAhPSAn LScpCj4gKwkJCSsrZGlybmFtZTsKPiAgCj4gLQlpZiAoIWRhdGEtPnJlcykKPiAtCQlyZXR1cm4g MDsKPiArCQlpZigqZGlybmFtZSA9PSAnLScpCj4gKwkJCSsrZGlybmFtZTsKPiAgCj4gLQlmb3Ig KGludCBpID0gMDsgaSA8IGRhdGEtPnJlcy0+Y291bnRfY29ubmVjdG9yczsgaSsrKQo+IC0JCWlm IChkYXRhLT5lZGlkc1tpXSAmJiBlZGlkX2lzX3ZhbGlkKGRhdGEtPmVkaWRzW2ldLT5kYXRhKSkK PiAtCQkJcmV0Kys7Cj4gLQlyZXR1cm4gcmV0Owo+ICsJCWlmIChzdHJjbXAoZGlybmFtZSwgY29u bmVjdG9yX25hbWUpID09IDApIHsKPiArCQkJY29ubmVjdG9yX2ZkID0gb3BlbmF0KHN5c2ZzX2Nh cmRfZmQsIGRpcmVudC0+ZF9uYW1lLCBPX1JET05MWSk7Cj4gKwkJCWJyZWFrOwo+ICsJCX0KPiAr CX0KPiArCWNsb3NlZGlyKGRpcik7Cj4gKwo+ICsJaWYoY29ubmVjdG9yX2ZkIDwgMCkKPiArCQly ZXR1cm4gZmFsc2U7Cj4gKwo+ICsJZGlyID0gZmRvcGVuZGlyKGNvbm5lY3Rvcl9mZCk7Cj4gKwlp Z3RfYXNzZXJ0KGRpcik7Cj4gKwo+ICsJd2hpbGUgKChkaXJlbnQgPSByZWFkZGlyKGRpcikpKSB7 Cj4gKwkJaWYgKHN0cm5jbXAoZGlyZW50LT5kX25hbWUsICJpMmMtIiwgNCkgPT0gMCkgewo+ICsJ CQlzcHJpbnRmKGkyY19wYXRoLCAiL2Rldi8lcyIsIGRpcmVudC0+ZF9uYW1lKTsKPiArCQkJZm91 bmRfaTJjX2ZpbGUgPSB0cnVlOwo+ICsJCX0KPiArCX0KPiArCWNsb3NlZGlyKGRpcik7Cj4gKwly ZXR1cm4gZm91bmRfaTJjX2ZpbGU7Cj4gIH0KPiAgCj4gLXN0YXRpYyBib29sIGkyY19lZGlkX2lz X3ZhbGlkKGludCBmZCkKPiArCj4gK3N0YXRpYyBib29sIGkyY19yZWFkX2VkaWQoY2hhciAqY29u bmVjdG9yX25hbWUsIHVuc2lnbmVkIGNoYXIgKmVkaWQpCj4gIHsKPiAtCWludCByYzsKPiAtCXVu c2lnbmVkIGNoYXIgZWRpZFsxMjhdID0ge307Cj4gKwljaGFyIGkyY19wYXRoW1BBVEhfTUFYXTsK PiArCWJvb2wgcmVzdWx0ID0gZmluZF9pMmNfcGF0aChjb25uZWN0b3JfbmFtZSwgaTJjX3BhdGgp Owo+ICsJaW50IHJjLCBmZDsKPiArCj4gIAlzdHJ1Y3QgaTJjX21zZyBtc2dzW10gPSB7Cj4gIAkJ eyAvKiBTdGFydCBhdCAwLiAqLwo+ICAJCQkuYWRkciA9IDB4NTAsCj4gQEAgLTYxNiw2OSArNjM5 LDg2IEBAIHN0YXRpYyBib29sIGkyY19lZGlkX2lzX3ZhbGlkKGludCBmZCkKPiAgCQkubm1zZ3Mg PSAyLAo+ICAJfTsKPiAgCj4gKwo+ICsJaWYgKCFyZXN1bHQpCj4gKwkJcmV0dXJuIGZhbHNlOwo+ ICsKPiArCWZkID0gb3BlbihpMmNfcGF0aCwgT19SRFdSKTsKPiArCWlndF9hc3NlcnRfbmVxKGZk LCAtMSk7Cj4gKwo+ICAJcmMgPSBpb2N0bChmZCwgSTJDX1JEV1IsICZtc2dzZXQpOwo+IC0JcmV0 dXJuIChyYyA+PSAwKSA/IGVkaWRfaXNfdmFsaWQoZWRpZCkgOiBmYWxzZTsKPiArCj4gKwljbG9z ZShmZCk7Cj4gKwlyZXR1cm4gcmMgPj0gMDsKPiAgfQo+ICAKPiAtc3RhdGljIGludCBjb3VudF9p MmNfdmFsaWRfZWRpZHModm9pZCkKPiArc3RhdGljIHZvaWQgZm9ybWF0X2hleF9zdHJpbmcodW5z aWduZWQgY2hhciBlZGlkW3N0YXRpYyBFRElEX0xFTkdUSF0sCj4gKwkJCSAgICAgIGNoYXIgYnVm W3N0YXRpYyBFRElEX0xFTkdUSCAqIDUgKyAxXSkKPiAgewo+IC0JaW50IGZkLCByZXQgPSAwOwo+ IC0JRElSICpkaXI7Cj4gKwlmb3IgKHNpemVfdCBpID0gMDsgaSA8IEVESURfTEVOR1RIOyArK2kp Cj4gKwkJc3ByaW50ZihidWYraSo1LCAiMHglMDJ4ICIsIGVkaWRbaV0pOwo+ICt9Cj4gIAo+IC0J c3RydWN0IGRpcmVudCAqZGlyZW50Owo+IC0JY2hhciBmdWxsX25hbWVbUEFUSF9NQVhdOwo+ICtz dGF0aWMgdm9pZCB0ZXN0X2kyYyhzdHJ1Y3QgbW9kZV9zZXRfZGF0YSAqZGF0YSkKPiArewo+ICsJ Ym9vbCBmYWlsZWQgPSBmYWxzZTsKPiArCWlndF9kaXNwbGF5X3QgZGlzcGxheTsKPiArCWlndF9k aXNwbGF5X3JlcXVpcmUoJmRpc3BsYXksIGRybV9mZCk7Cj4gIAo+IC0JZGlyID0gb3BlbmRpcigi L2Rldi8iKTsKPiAtCWlndF9hc3NlcnQoZGlyKTsKPiArCWZvciAoaW50IGkgPSAwOyBpIDwgZGF0 YS0+cmVzLT5jb3VudF9jb25uZWN0b3JzOyBpKyspIHsKPiArCQl1bnNpZ25lZCBjaGFyICpkcm1f ZWRpZCA9IGRhdGEtPmVkaWRzW2ldID8gZGF0YS0+ZWRpZHNbaV0tPmRhdGEgOiBOVUxMOwo+ICsJ CXVuc2lnbmVkIGNoYXIgaTJjX2VkaWRbRURJRF9MRU5HVEhdID0ge307Cj4gIAo+IC0Jd2hpbGUg KChkaXJlbnQgPSByZWFkZGlyKGRpcikpKSB7Cj4gLQkJaWYgKHN0cm5jbXAoZGlyZW50LT5kX25h bWUsICJpMmMtIiwgNCkgPT0gMCkgewo+IC0JCQlzcHJpbnRmKGZ1bGxfbmFtZSwgIi9kZXYvJXMi LCBkaXJlbnQtPmRfbmFtZSk7Cj4gLQkJCWZkID0gb3BlbihmdWxsX25hbWUsIE9fUkRXUik7Cj4g LQkJCWlndF9hc3NlcnRfbmVxKGZkLCAtMSk7Cj4gLQkJCWlmIChpMmNfZWRpZF9pc192YWxpZChm ZCkpCj4gLQkJCQlyZXQrKzsKPiAtCQkJY2xvc2UoZmQpOwo+IC0JCX0KPiAtCX0KPiArCQlpZ3Rf b3V0cHV0X3QgKm91dHB1dCA9IGlndF9vdXRwdXRfZnJvbV9jb25uZWN0b3IoJmRpc3BsYXksCj4g KwkJCQkJCQkJIGRhdGEtPmNvbm5lY3RvcnNbaV0pOwo+ICsJCWNoYXIgKmNvbm5lY3Rvcl9uYW1l ID0gKGNoYXIgKikgaWd0X291dHB1dF9uYW1lKG91dHB1dCk7Cj4gIAo+IC0JY2xvc2VkaXIoZGly KTsKPiArCQlib29sIGdvdF9pMmNfZWRpZCA9IGkyY19yZWFkX2VkaWQoY29ubmVjdG9yX25hbWUs IGkyY19lZGlkKTsKPiArCQlib29sIGdvdF9kcm1fZWRpZCA9IGRybV9lZGlkICE9IE5VTEw7Cj4g KwkJYm9vbCBpc192Z2EgPSBkYXRhLT5jb25uZWN0b3JzW2ldLT5jb25uZWN0b3JfdHlwZSA9PSBE Uk1fTU9ERV9DT05ORUNUT1JfVkdBOwo+ICAKPiAtCXJldHVybiByZXQ7Cj4gLX0KPiArCQlib29s IGVkaWRzX2VxdWFsOwo+ICAKPiAtc3RhdGljIGludCBjb3VudF92Z2Ffb3V0cHV0cyhzdHJ1Y3Qg bW9kZV9zZXRfZGF0YSAqZGF0YSkKPiAtewo+IC0JaW50IGNvdW50ID0gMDsKPiArCQkvKiBXZSBm YWlsIHRvIGRldGVjdCBzb21lIFZHQSBtb25pdG9ycyB1c2luZyBvdXIgaTJjIG1ldGhvZC4gSWYg eW91IGxvb2sKPiArCQkgKiBhdCB0aGUgZG1lc2cgb2YgdGhlc2UgY2FzZXMsIHlvdSdsbCBzZWUg dGhlIEtlcm5lbCBjb21wbGFpbmluZyBhYm91dAo+ICsJCSAqIHRoZSBFRElEIHJlYWRpbmcgbW9z dGx5IEZGcyBhbmQgdGhlbiBkaXNhYmxpbmcgYml0LWJhbmdpbmcuIFNpbmNlIHdlCj4gKwkJICog ZG9uJ3Qgd2FudCB0byByZWltcGxlbWVudCBldmVyeXRoaW5nIHRoZSBLZXJuZWwgZG9lcywgbGV0 J3MganVzdAo+ICsJCSAqIGFjY2VwdCB0aGUgZmFjdCB0aGF0IHNvbWUgVkdBIG91dHB1dHMgd29u J3QgYmUgcHJvcGVybHkgZGV0ZWN0ZWQuICovCj4gKwkJaWYoaXNfdmdhKQo+ICsJCQljb250aW51 ZTsKPiAgCj4gLQlpZiAoIWRhdGEtPnJlcykKPiAtCQlyZXR1cm4gMDsKPiArCQlpZighZ290X2ky Y19lZGlkICYmICFnb3RfZHJtX2VkaWQpCj4gKwkJCWNvbnRpbnVlOwo+ICsKPiArCQlpZihnb3Rf aTJjX2VkaWQgJiYgZ290X2RybV9lZGlkKQo+ICsJCQllZGlkc19lcXVhbCA9ICgwID09IG1lbWNt cChkcm1fZWRpZCwgaTJjX2VkaWQsIEVESURfTEVOR1RIKSk7Cj4gKwkJZWxzZQo+ICsJCQllZGlk c19lcXVhbCA9IGZhbHNlOwo+ICAKPiAtCWZvciAoaW50IGkgPSAwOyBpIDwgZGF0YS0+cmVzLT5j b3VudF9jb25uZWN0b3JzOyBpKyspCj4gLQkJaWYgKGRhdGEtPmNvbm5lY3RvcnNbaV0tPmNvbm5l Y3Rvcl90eXBlID09Cj4gLQkJICAgIERSTV9NT0RFX0NPTk5FQ1RPUl9WR0EpCj4gLQkJCWNvdW50 Kys7Cj4gIAo+IC0JcmV0dXJuIGNvdW50Owo+IC19Cj4gKwkJaWYgKCFlZGlkc19lcXVhbCkgewo+ ICsJCQljaGFyIGJ1Zls1ICogRURJRF9MRU5HVEggKyAxXTsKPiArCQkJaWd0X2NyaXRpY2FsKCJG b3IgY29ubmVjdG9yICVzIEVESUQgbWlzbWF0Y2ghXG4iLAo+ICsJCQkJICAgICBjb25uZWN0b3Jf bmFtZSk7Cj4gIAo+IC1zdGF0aWMgdm9pZCB0ZXN0X2kyYyhzdHJ1Y3QgbW9kZV9zZXRfZGF0YSAq ZGF0YSkKPiAtewo+IC0JaW50IGkyY19lZGlkcyA9IGNvdW50X2kyY192YWxpZF9lZGlkcygpOwo+ IC0JaW50IGRybV9lZGlkcyA9IGNvdW50X2RybV92YWxpZF9lZGlkcyhkYXRhKTsKPiAtCWludCB2 Z2Ffb3V0cHV0cyA9IGNvdW50X3ZnYV9vdXRwdXRzKGRhdGEpOwo+IC0JaW50IGRpZmY7Cj4gLQo+ IC0JaWd0X2RlYnVnKCJpMmMgZWRpZHM6JWQgZHJtIGVkaWRzOiVkIHZnYSBvdXRwdXRzOiVkXG4i LAo+IC0JCSAgaTJjX2VkaWRzLCBkcm1fZWRpZHMsIHZnYV9vdXRwdXRzKTsKPiAtCj4gLQkvKiBX ZSBmYWlsIHRvIGRldGVjdCBzb21lIFZHQSBtb25pdG9ycyB1c2luZyBvdXIgaTJjIG1ldGhvZC4g SWYgeW91IGxvb2sKPiAtCSAqIGF0IHRoZSBkbWVzZyBvZiB0aGVzZSBjYXNlcywgeW91J2xsIHNl ZSB0aGUgS2VybmVsIGNvbXBsYWluaW5nIGFib3V0Cj4gLQkgKiB0aGUgRURJRCByZWFkaW5nIG1v c3RseSBGRnMgYW5kIHRoZW4gZGlzYWJsaW5nIGJpdC1iYW5naW5nLiBTaW5jZSB3ZQo+IC0JICog ZG9uJ3Qgd2FudCB0byByZWltcGxlbWVudCBldmVyeXRoaW5nIHRoZSBLZXJuZWwgZG9lcywgbGV0 J3MganVzdAo+IC0JICogYWNjZXB0IHRoZSBmYWN0IHRoYXQgc29tZSBWR0Egb3V0cHV0cyB3b24n dCBiZSBwcm9wZXJseSBkZXRlY3RlZC4gKi8KPiAtCWRpZmYgPSBkcm1fZWRpZHMgLSBpMmNfZWRp ZHM7Cj4gLQlpZ3RfYXNzZXJ0KGRpZmYgPD0gdmdhX291dHB1dHMgJiYgZGlmZiA+PSAwKTsKPiAr CQkJaWYoZ290X2kyY19lZGlkKQo+ICsJCQkJZm9ybWF0X2hleF9zdHJpbmcoaTJjX2VkaWQsIGJ1 Zik7Cj4gKwkJCWVsc2UKPiArCQkJCXNwcmludGYoYnVmLCAiTlVMTCIpOwo+ICsKPiArCQkJaWd0 X2NyaXRpY2FsKCJpMmM6ICVzXG4iLCBidWYpOwo+ICsKPiArCQkJaWYoZ290X2RybV9lZGlkKQo+ ICsJCQkJZm9ybWF0X2hleF9zdHJpbmcoZHJtX2VkaWQsIGJ1Zik7Cj4gKwkJCWVsc2UKPiArCQkJ CXNwcmludGYoYnVmLCAiTlVMTCIpOwo+ICsKPiArCQkJaWd0X2NyaXRpY2FsKCJkcm06ICVzXG4i LCBidWYpOwo+ICsKPiArCQkJZmFpbGVkID0gdHJ1ZTsKPiArCQl9Cj4gKwl9Cj4gKwlpZ3RfZmFp bF9vbl9mKGZhaWxlZCwgIk1pc21hdGNoIG9uIEVESUQgd2UgZ290IGZyb20gaTJjIGFuZCBEUk0h XG4iKTsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgc2V0dXBfcGM4KHZvaWQpCj4gLS0gCj4gMi4y MS4wCj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmln dC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldg==