Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 01/21] scripts/trace.pl: Fix after intel_engine_notify removal

Tvrtko Ursulin
2019-05-09T09:27:41Z

On 08/05/2019 13:17, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-05-08 13:10:38)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> After the removal of engine global seqnos and the corresponding
>> intel_engine_notify tracepoints the script needs to be adjusted to cope
>> with the new state of things.
>>
>> To keep working it switches over using the dma_fence:dma_fence_signaled:
>> tracepoint and keeps one extra internal map to connect the ctx-seqno pairs
>> with engines.
>
> Is the map suitable for the planned (by me)
>
> s/i915_request_wait_begin/dma_fence_wait_begin/
>
> I guess it should be.

I think it would be workable. One complication would be that engine is
not guaranteed to be known ahead of the wait, like it is ahead of the
signal. But since ctx.seqno is unique it can be tracked and added later
I think.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org