From: Daniel Vetter <daniel@ffwll.ch>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: igt-dev@lists.freedesktop.org, Petri Latvala <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] meson: Explicitly require libcurl for chamelium
Date: Thu, 9 May 2019 10:01:56 +0200 [thread overview]
Message-ID: <20190509080156.GC17751@phenom.ffwll.local> (raw)
In-Reply-To: <20190509075600.19509-1-arkadiusz.hiler@intel.com>
On Thu, May 09, 2019 at 10:56:00AM +0300, Arkadiusz Hiler wrote:
> Chamelium uses xmlrpc client which:
>
> $ xmlrpc-c-config client --libs
> -L/usr/lib/x86_64-linux-gnu -lxmlrpc_client -lxmlrpc -lxmlrpc_xmlparse -lxmlrpc_xmltok -lxmlrpc_util -lcurl
>
> Debian/Ubuntu (and perhaps others) lack dependency on libcurl-dev:
>
> $ apt depends libxmlrpc-core-c3-dev
> Depends: libxmlrpc-core-c3 (= 1.33.14-4)
> Suggests: xmlrpc-api-utils
>
> $ apt depends libxmlrpc-core-c3
> libxmlrpc-core-c3
> Depends: libc6 (>= 2.14)
> Depends: libcurl3 (>= 7.16.2)
>
> Which causes:
>
> /usr/bin/ld: cannot find -lcurl
> collect2: error: ld returned 1 exit status
> [14/711] Compiling C object 'tests/59830eb@@kms_atomic@exe/kms_atomic.c.o'.
> ninja: build stopped: subcommand failed.
>
> Debian's `reportbug` was used to report this issue.
> Meanwhile we can explicitly ask for libcurl.
>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> meson.build | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 8196ab63..cbc37f7e 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -196,6 +196,7 @@ chameliuminfo = 'No'
> if _build_chamelium
> gsl = dependency('gsl', required : _chamelium_required)
> alsa = dependency('alsa', required : _chamelium_required)
> + libcurl = dependency('libcurl', required : _chamelium_required)
> chamelium = declare_dependency(dependencies : [
> xmlrpc,
> xmlrpc_util,
> @@ -203,7 +204,7 @@ if _build_chamelium
> gsl,
> alsa,
> ], required : _chamelium_required)
> - if xmlrpc.found() and xmlrpc_util.found() and xmlrpc_client.found() and gsl.found() and alsa.found()
> + if xmlrpc.found() and xmlrpc_util.found() and xmlrpc_client.found() and gsl.found() and alsa.found() and libcurl.found()
> config.set('HAVE_CHAMELIUM', 1)
> chameliuminfo = 'Yes'
> chamelium_found = true
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-05-09 8:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 7:56 [igt-dev] [PATCH i-g-t] meson: Explicitly require libcurl for chamelium Arkadiusz Hiler
2019-05-09 8:01 ` Daniel Vetter [this message]
2019-05-09 10:58 ` Petri Latvala
2019-05-09 11:05 ` Petri Latvala
2019-05-09 11:01 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-05-09 13:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509080156.GC17751@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox