From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 76B4389951 for ; Thu, 9 May 2019 08:19:13 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id j12so476943eds.7 for ; Thu, 09 May 2019 01:19:13 -0700 (PDT) Date: Thu, 9 May 2019 10:19:09 +0200 From: Daniel Vetter Message-ID: <20190509081909.GD17751@phenom.ffwll.local> References: <20190508201512.14263-1-lyude@redhat.com> <20190508201512.14263-3-lyude@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190508201512.14263-3-lyude@redhat.com> Subject: Re: [igt-dev] [PATCH i-g-t 2/3] lib/aux: Call setgroups() in igt_drop_root() before setgid() List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Lyude Cc: igt-dev@lists.freedesktop.org, Petri Latvala List-ID: T24gV2VkLCBNYXkgMDgsIDIwMTkgYXQgMDQ6MTU6MTFQTSAtMDQwMCwgTHl1ZGUgd3JvdGU6Cj4g RnJvbTogTHl1ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNvbT4KPiAKPiBXaGlsZSBpZ3QgaXNuJ3Qg cmVhbGx5IHNlY3VyaXR5IHNlbnNpdGl2ZSwgZm9yZ2V0dGluZyB0byBjYWxsCj4gc2V0Z3JvdXBz KCkgYmVmb3JlIGNhbGxpbmcgc2V0Z2lkKCkgY2F1c2VzIHJwbWxpbnQgb24gRmVkb3JhIHRvCj4g Y29tcGxhaW46Cj4gCj4gICBpZ3QtZ3B1LXRvb2xzLng4Nl82NDogRTogbWlzc2luZy1jYWxsLXRv LXNldGdyb3Vwcy1iZWZvcmUtc2V0dWlkCj4gICAvdXNyL2xpYjY0L2xpYmlndC5zby4wCj4gICAu Li4KPiAgIG1pc3NpbmctY2FsbC10by1zZXRncm91cHMtYmVmb3JlLXNldHVpZDoKPiAgIFRoaXMg ZXhlY3V0YWJsZSBpcyBjYWxsaW5nIHNldHVpZCBhbmQgc2V0Z2lkIHdpdGhvdXQgc2V0Z3JvdXBz IG9yCj4gICBpbml0Z3JvdXBzLiBUaGVyZSBpcyBhIGhpZ2ggcHJvYmFiaWxpdHkgdGhpcyBtZWFu cyBpdCBkaWRuJ3QgcmVsaW5xdWlzaAo+ICAgYWxsIGdyb3VwcywgYW5kIHRoaXMgd291bGQgYmUg YSBwb3RlbnRpYWwgc2VjdXJpdHkgaXNzdWUgdG8gYmUgZml4ZWQuCj4gICBTZWVrIFBPUzM2LUMg b24gdGhlIHdlYiBmb3IgZGV0YWlscyBhYm91dCB0aGUgcHJvYmxlbS4KPiAKPiBTaW5jZSBpdCdz IGxpa2VseSBvdGhlciBwYWNrYWdlIG1haW50YWluZXJzIGZvciBvdGhlciBkaXN0cm9zIHdpbGwg aGF2ZQo+IHRvIGRlYWwgd2l0aCBzaW1pbGFyIGlzc3VlcyBldmVudHVhbGx5LCBhbmQgSSBjYW4n dCBzZWUgYW55IGhhcm0gaW4gaXQsCj4gbGV0J3MgZG8gdGhlIHJpZ2h0IHRoaW5nIGFuZCBjYWxs IHNldGdyb3VwcygpIGZpcnN0LgoKWWVhaCBpZ3QgaXMgbW9yZSBhIHBpbGUgb2YgZXhwbG9pdHMg cmVhbGx5IDotKQoKT24gdGhlIHNlcmllczogUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRh bmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gCj4gU2lnbmVkLW9mZi1ieTogTHl1ZGUgUGF1bCA8bHl1 ZGVAcmVkaGF0LmNvbT4KPiAtLS0KPiAgbGliL2lndF9hdXguYyB8IDMgKysrCj4gIDEgZmlsZSBj aGFuZ2VkLCAzIGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9hdXguYyBi L2xpYi9pZ3RfYXV4LmMKPiBpbmRleCBjYWVkMWZlZC4uNTc4Zjg1NzkgMTAwNjQ0Cj4gLS0tIGEv bGliL2lndF9hdXguYwo+ICsrKyBiL2xpYi9pZ3RfYXV4LmMKPiBAQCAtNDksNiArNDksNyBAQAo+ ICAjaW5jbHVkZSA8c3lzL3V0c25hbWUuaD4KPiAgI2luY2x1ZGUgPHRlcm1pb3MuaD4KPiAgI2lu Y2x1ZGUgPGFzc2VydC5oPgo+ICsjaW5jbHVkZSA8Z3JwLmg+Cj4gIAo+ICAjaW5jbHVkZSA8cHJv Yy9yZWFkcHJvYy5oPgo+ICAjaW5jbHVkZSA8bGlidWRldi5oPgo+IEBAIC05NTksOSArOTYwLDEx IEBAIHZvaWQgaWd0X2Ryb3Bfcm9vdCh2b2lkKQo+ICB7Cj4gIAlpZ3RfYXNzZXJ0X2VxKGdldHVp ZCgpLCAwKTsKPiAgCj4gKwlpZ3RfYXNzZXJ0X2VxKHNldGdyb3VwcygwLCBOVUxMKSwgMCk7Cj4g IAlpZ3RfYXNzZXJ0X2VxKHNldGdpZCgyKSwgMCk7Cj4gIAlpZ3RfYXNzZXJ0X2VxKHNldHVpZCgy KSwgMCk7Cj4gIAo+ICsJaWd0X2Fzc2VydF9lcShnZXRncm91cHMoMCwgTlVMTCksIDApOwo+ICAJ aWd0X2Fzc2VydF9lcShnZXRnaWQoKSwgMik7Cj4gIAlpZ3RfYXNzZXJ0X2VxKGdldHVpZCgpLCAy KTsKPiAgfQo+IC0tIAo+IDIuMjAuMQo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCj4gaWd0LWRldiBtYWlsaW5nIGxpc3QKPiBpZ3QtZGV2QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaWd0LWRldgoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIElu dGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaWd0LWRldg==