Re: [igt-dev] [PATCH v24 04/14] lib: igt_gt: make gem_engine_can_store_dword() check engine class

From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: IGT dev <igt-dev@lists.freedesktop.org>,
	Andi Shyti <andi@etezian.org>,
	Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [igt-dev] [PATCH v24 04/14] lib: igt_gt: make gem_engine_can_store_dword() check engine class
Date: Tue, 14 May 2019 12:25:18 +0300	[thread overview]
Message-ID: <20190514092518.GA2720@intel.intel> (raw)
In-Reply-To: <155782487795.2525.16323516297882838434@skylake-alporthouse-com>

Hi Chris,

On Tue, May 14, 2019 at 10:07:57AM +0100, Chris Wilson wrote:
> Quoting Andi Shyti (2019-05-13 18:56:03)
> > -bool gem_can_store_dword(int fd, unsigned int engine)
> > +bool gem_class_can_store_dword(int fd, int class)
> >  {
> >         uint16_t devid = intel_get_drm_devid(fd);
> >         const struct intel_device_info *info = intel_get_device_info(devid);
> > @@ -569,8 +569,8 @@ bool gem_can_store_dword(int fd, unsigned int engine)
> >         if (gen == 3 && (info->is_grantsdale || info->is_alviso))
> >                 return false; /* only supports physical addresses */
> >  
> > -       if (gen == 6 && ((engine & 0x3f) == I915_EXEC_BSD))
> > -               return false; /* kills the machine! */
> > +       if (gen == 6 && class == I915_ENGINE_CLASS_VIDEO)
> > +               return false;
> 
> Probably wise to keep the note about why it is excluded. It's a nasty
> surprise.

I have another patch ready on this one with one of your Suggested-by
that I will send later in a different patchset.

Andi
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev