Re: [igt-dev] [PATCH i-g-t 04/15] gem_wsim: Engine map load balance command

Tvrtko Ursulin
2019-05-23T13:58:00Z

On 23/05/2019 14:25, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-05-22 16:57:09)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> A new workload command for enabling a load balanced context map (aka
>> Virtual Engine). Example usage:
>>
>> B.1
>>
>> This turns on load balancing for context one, assuming it has already been
>> configured with an engine map. Only DEFAULT engine specifier can be used
>> with load balanced engine maps.
>>
>> v2:
>> * Lift restriction to only use load balancer when enabled in context map.
>> (Chris)
>
> You didn't fancy going all out and say:
> B.1.DEFAULT.VCS1|VCS2
> ?
>
> If you are happy with the current code, it looks to do what you want,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Thanks, I wouldn't say I am happy as in really proud of it happy. But as
a tool by hackers for hackers, which grew organically always as a second
priority thing, it seems to work for now and is able to exercise the new
uAPI and scheduling paths.

So there is scope to tidy, and will certainly need more work in the
future (not least per engine calibration), but I need to call it done
for a while at some reasonable point and it feels like that should be now.

Proof in the pudding is that I think you found it useful when
benchmarking the semaphore code and related issues. So it at least
continues providing the same simulated workloads over the new uAPI.

Regards,

Tvrtko