Re: [igt-dev] [PATCH i-g-t] tests/i915: Restore some BAT coverage

Andi Shyti
2019-05-22T21:28:24Z

Hi Tvrtko,

> +static void all(int i915)
> +{
> + const struct intel_execution_engine2 *e;
> +
> + __for_each_physical_engine(i915, e)
> + basic(i915, e, false);

ops... there is an error in my previous patch.

I restored the meaining of flags because you and Chris didn't
like the boolean true/false meaning, indeed here I still check
with:

if ((flags & HANG) == 0) {

but then I forgot to update the test cases.

This means that this line needs to be

basic(i915, e, 0);

as the rest.

I'm sorry about the confusion! In any case,

Reviewed-by: Andi Shyti <andi.shyti@intel.com>

Thanks,
Andi