Re: [Intel-gfx] [PATCH i-g-t v2] tests/i915: Restore some BAT coverage

Chris Wilson
2019-05-23T11:43:31Z

Quoting Tvrtko Ursulin (2019-05-23 07:37:01)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Engine enumerated test names have changed so fast-feedback.testlist needs
> to be updated. However listing all engines there won't scale. So instead
> add new tests cases which iterate all engines internally.
>
> v2:
> * Fix basic-all test name.
> * Fix params to basic (bool false to zero).
> * Use I915_EXEC_DEFAULT in has_extended_busy_ioctl to workaround stateful
> contexts for now.
> * Have only basic-all in BAT. (Chris)
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> # v1
> Reviewed-by: Andi Shyti <andi.shyti@intel.com> # v1
> ---
> tests/i915/gem_busy.c | 19 +++++++++++----
> tests/i915/gem_exec_basic.c | 33 +++++++++++++++++++++++++++
> tests/intel-ci/fast-feedback.testlist | 31 ++-----------------------
> 3 files changed, 50 insertions(+), 33 deletions(-)
>
> diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
> index 781a3bfab1d1..f3ebb37a33b4 100644
> --- a/tests/i915/gem_busy.c
> +++ b/tests/i915/gem_busy.c
> @@ -417,7 +417,7 @@ static bool has_semaphores(int fd)
>
> static bool has_extended_busy_ioctl(int fd)
> {
> - igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_RENDER);
> + igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_DEFAULT);

I vote for igt_spin_t *spin = igt_spin_new(fd); for ultra-funkiness.

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org