public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@intel.com>
To: IGT dev <igt-dev@lists.freedesktop.org>
Cc: Andi Shyti <andi@etezian.org>
Subject: [igt-dev] [PATCH] test/i915: gem_busy: fix misuse of the "flags" parameter in basic()
Date: Thu, 23 May 2019 01:13:02 +0300	[thread overview]
Message-ID: <20190522221302.2537-1-andi.shyti@intel.com> (raw)

The "flags" parameter received by the "basic()" function checks
for the HANG (0x2) bit, while callers give it a boolean
true/false value.

Restore the original meaning of "flags" as a bit mask.

Fixes: 88318b0771f9 ("test/i915: gem_busy: use the gem_engine_topology library")
Signed-off-by: Andi Shyti <andi.shyti@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 tests/i915/gem_busy.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
index 2872e7b7be62..781a3bfab1d1 100644
--- a/tests/i915/gem_busy.c
+++ b/tests/i915/gem_busy.c
@@ -483,7 +483,7 @@ igt_main
 					      e->class == I915_ENGINE_CLASS_RENDER
 					      ? "basic-" : "", e->name) {
 					gem_quiescent_gpu(fd);
-					basic(fd, e, false);
+					basic(fd, e, 0);
 				}
 			}
 		}
@@ -548,7 +548,7 @@ igt_main
 				      ? "basic-" : "", e->name) {
 				igt_skip_on_simulation();
 				gem_quiescent_gpu(fd);
-				basic(fd, e, true);
+				basic(fd, e, HANG);
 			}
 		}
 
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2019-05-22 22:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22 22:13 Andi Shyti [this message]
2019-05-22 22:42 ` [igt-dev] [PATCH] test/i915: gem_busy: fix misuse of the "flags" parameter in basic() Chris Wilson
2019-05-22 23:12 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190522221302.2537-1-andi.shyti@intel.com \
    --to=andi.shyti@intel.com \
    --cc=andi@etezian.org \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox