From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 29 May 2019 11:12:44 +0300 From: Petri Latvala Message-ID: <20190529081244.GR22949@platvala-desk.ger.corp.intel.com> References: <20190527083616.27372-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190527083616.27372-1-chris@chris-wilson.co.uk> Subject: Re: [igt-dev] [PATCH i-g-t] prime_vgem: Fix typo in checking for invalid engines List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org List-ID: T24gTW9uLCBNYXkgMjcsIDIwMTkgYXQgMDk6MzY6MTZBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE1vdmUgdGhlIHN0cmF5ICcpJyBmcm9tCj4gCj4gCWdlbV9jYW5fc3RvcmVfZHdvcmQo ZXhlY19pZCkgfCBleGVjX2ZsYWdzCj4gCj4gdG8KPiAKPiAJZ2VtX2Nhbl9zdG9yZV9kd29yZChl eGVjX2lkIHwgZXhlY19mbGFncykKPiAKPiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNr dG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwNzY0Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2ls c29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+CgpSZXZpZXdlZC1ieTogUGV0cmkgTGF0dmFs YSA8cGV0cmkubGF0dmFsYUBpbnRlbC5jb20+Cgo+IC0tLQo+ICB0ZXN0cy9wcmltZV92Z2VtLmMg fCA4ICsrKystLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRp b25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL3Rlc3RzL3ByaW1lX3ZnZW0uYyBiL3Rlc3RzL3ByaW1l X3ZnZW0uYwo+IGluZGV4IDA5ZTMzNzNiZS4uNjlhZThjOWIwIDEwMDY0NAo+IC0tLSBhL3Rlc3Rz L3ByaW1lX3ZnZW0uYwo+ICsrKyBiL3Rlc3RzL3ByaW1lX3ZnZW0uYwo+IEBAIC04NDUsNyArODQ1 LDcgQEAgaWd0X21haW4KPiAgCQkJICAgICAgZS0+ZXhlY19pZCA9PSAwID8gImJhc2ljLSIgOiAi IiwKPiAgCQkJICAgICAgZS0+bmFtZSkgewo+ICAJCQlnZW1fcmVxdWlyZV9yaW5nKGk5MTUsIGUt PmV4ZWNfaWQgfCBlLT5mbGFncyk7Cj4gLQkJCWlndF9yZXF1aXJlKGdlbV9jYW5fc3RvcmVfZHdv cmQoaTkxNSwgZS0+ZXhlY19pZCkgfCBlLT5mbGFncyk7Cj4gKwkJCWlndF9yZXF1aXJlKGdlbV9j YW5fc3RvcmVfZHdvcmQoaTkxNSwgZS0+ZXhlY19pZCB8IGUtPmZsYWdzKSk7Cj4gIAo+ICAJCQln ZW1fcXVpZXNjZW50X2dwdShpOTE1KTsKPiAgCQkJdGVzdF9zeW5jKGk5MTUsIHZnZW0sIGUtPmV4 ZWNfaWQsIGUtPmZsYWdzKTsKPiBAQCAtODU3LDcgKzg1Nyw3IEBAIGlndF9tYWluCj4gIAkJCSAg ICAgIGUtPmV4ZWNfaWQgPT0gMCA/ICJiYXNpYy0iIDogIiIsCj4gIAkJCSAgICAgIGUtPm5hbWUp IHsKPiAgCQkJZ2VtX3JlcXVpcmVfcmluZyhpOTE1LCBlLT5leGVjX2lkIHwgZS0+ZmxhZ3MpOwo+ IC0JCQlpZ3RfcmVxdWlyZShnZW1fY2FuX3N0b3JlX2R3b3JkKGk5MTUsIGUtPmV4ZWNfaWQpIHwg ZS0+ZmxhZ3MpOwo+ICsJCQlpZ3RfcmVxdWlyZShnZW1fY2FuX3N0b3JlX2R3b3JkKGk5MTUsIGUt PmV4ZWNfaWQgfCBlLT5mbGFncykpOwo+ICAKPiAgCQkJZ2VtX3F1aWVzY2VudF9ncHUoaTkxNSk7 Cj4gIAkJCXRlc3RfYnVzeShpOTE1LCB2Z2VtLCBlLT5leGVjX2lkLCBlLT5mbGFncyk7Cj4gQEAg LTg2OSw3ICs4NjksNyBAQCBpZ3RfbWFpbgo+ICAJCQkgICAgICBlLT5leGVjX2lkID09IDAgPyAi YmFzaWMtIiA6ICIiLAo+ICAJCQkgICAgICBlLT5uYW1lKSB7Cj4gIAkJCWdlbV9yZXF1aXJlX3Jp bmcoaTkxNSwgZS0+ZXhlY19pZCB8IGUtPmZsYWdzKTsKPiAtCQkJaWd0X3JlcXVpcmUoZ2VtX2Nh bl9zdG9yZV9kd29yZChpOTE1LCBlLT5leGVjX2lkKSB8IGUtPmZsYWdzKTsKPiArCQkJaWd0X3Jl cXVpcmUoZ2VtX2Nhbl9zdG9yZV9kd29yZChpOTE1LCBlLT5leGVjX2lkIHwgZS0+ZmxhZ3MpKTsK PiAgCj4gIAkJCWdlbV9xdWllc2NlbnRfZ3B1KGk5MTUpOwo+ICAJCQl0ZXN0X3dhaXQoaTkxNSwg dmdlbSwgZS0+ZXhlY19pZCwgZS0+ZmxhZ3MpOwo+IEBAIC04OTIsNyArODkyLDcgQEAgaWd0X21h aW4KPiAgCQkJCQllLT5leGVjX2lkID09IDAgPyAiYmFzaWMtIiA6ICIiLAo+ICAJCQkJCWUtPm5h bWUpIHsKPiAgCQkJCWdlbV9yZXF1aXJlX3JpbmcoaTkxNSwgZS0+ZXhlY19pZCB8IGUtPmZsYWdz KTsKPiAtCQkJCWlndF9yZXF1aXJlKGdlbV9jYW5fc3RvcmVfZHdvcmQoaTkxNSwgZS0+ZXhlY19p ZCkgfCBlLT5mbGFncyk7Cj4gKwkJCQlpZ3RfcmVxdWlyZShnZW1fY2FuX3N0b3JlX2R3b3JkKGk5 MTUsIGUtPmV4ZWNfaWQgfCBlLT5mbGFncykpOwo+ICAKPiAgCQkJCWdlbV9xdWllc2NlbnRfZ3B1 KGk5MTUpOwo+ICAJCQkJdGVzdF9mZW5jZV93YWl0KGk5MTUsIHZnZW0sIGUtPmV4ZWNfaWQsIGUt PmZsYWdzKTsKPiAtLSAKPiAyLjIwLjEKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwo+IGlndC1kZXYgbWFpbGluZyBsaXN0Cj4gaWd0LWRldkBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2lndC1kZXYKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2