From: Petri Latvala <petri.latvala@intel.com>
To: "Ser, Simon" <simon.ser@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t 2/3] meson: Mark pciaccess and kmod as required
Date: Wed, 29 May 2019 13:57:28 +0300 [thread overview]
Message-ID: <20190529105727.GS22949@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <128385757b1ab1ee6c1f2396eafa6410676289fd.camel@intel.com>
On Wed, May 29, 2019 at 01:54:54PM +0300, Ser, Simon wrote:
> On Wed, 2019-05-29 at 13:51 +0300, Petri Latvala wrote:
> > libpciaccess and libkmod have been mandatory already, but not marked
> > as required.
>
> I thought mandatory deps were the default?
>
> In other words, I believe this:
>
> libkmod = dependency('libkmod')
>
> Makes libkmod a mandatory dep.
You're right, I got the default backwards!
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-05-29 10:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 10:51 [igt-dev] [PATCH i-g-t 1/3] meson: Remove redundant libdw from lib_deps Petri Latvala
2019-05-29 10:51 ` [igt-dev] [PATCH i-g-t 2/3] meson: Mark pciaccess and kmod as required Petri Latvala
2019-05-29 10:54 ` Ser, Simon
2019-05-29 10:57 ` Petri Latvala [this message]
2019-05-29 10:51 ` [igt-dev] [PATCH i-g-t 3/3] gitlab-CI: Do a build-test without any optional dependencies installed Petri Latvala
2019-05-29 11:07 ` Petri Latvala
2019-05-31 10:31 ` Ser, Simon
2019-05-29 10:55 ` [igt-dev] [PATCH i-g-t 1/3] meson: Remove redundant libdw from lib_deps Ser, Simon
2019-05-29 12:34 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] " Patchwork
2019-05-29 16:37 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529105727.GS22949@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=simon.ser@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox