public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Mika Kahola <mika.kahola@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/kms_flip_tiling: Check for mode when performing flip with Y/Yf tiling
Date: Wed, 29 May 2019 15:45:06 +0300	[thread overview]
Message-ID: <20190529124506.7335-1-mika.kahola@intel.com> (raw)

Kernel doesn't support Y or Yf tiling for interlaced modes. In kms_flip_tiling test case
we are missing such a check. Let's add a requirement that whenever we try to do flip with Y/Yf
tiling, we ensure that we have non-interlaced mode selected.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110772

Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
 tests/kms_flip_tiling.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tests/kms_flip_tiling.c b/tests/kms_flip_tiling.c
index d1e6687f..582af53c 100644
--- a/tests/kms_flip_tiling.c
+++ b/tests/kms_flip_tiling.c
@@ -75,6 +75,14 @@ test_flip_tiling(data_t *data, enum pipe pipe, igt_output_t *output, uint64_t ti
 	igt_output_set_pipe(output, pipe);
 
 	mode = igt_output_get_mode(output);
+
+	/* Interlaced modes don't support Y/Yf tiling */
+	if (tiling[0] == LOCAL_I915_FORMAT_MOD_Y_TILED ||
+	    tiling[0] == LOCAL_I915_FORMAT_MOD_Yf_TILED ||
+	    tiling[1] == LOCAL_I915_FORMAT_MOD_Y_TILED ||
+	    tiling[1] == LOCAL_I915_FORMAT_MOD_Yf_TILED)
+		igt_require(!(mode->flags & DRM_MODE_FLAG_INTERLACE));
+
 	primary = igt_output_get_plane(output, 0);
 
 	width = mode->hdisplay;
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2019-05-29 12:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-29 12:45 Mika Kahola [this message]
2019-05-29 14:29 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip_tiling: Check for mode when performing flip with Y/Yf tiling Patchwork
2019-05-29 20:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-05-31 12:11 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
2019-06-03  8:04   ` Kahola, Mika

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190529124506.7335-1-mika.kahola@intel.com \
    --to=mika.kahola@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox