Re: [igt-dev] [PATCH i-g-t] tests/kms_flip_tiling: Check for mode when performing flip with Y/Yf tiling

Kahola, Mika
2019-06-03T08:04:37Z

On Fri, 2019-05-31 at 15:11 +0300, Ville Syrjälä wrote:
> On Wed, May 29, 2019 at 03:45:06PM +0300, Mika Kahola wrote:
> > Kernel doesn't support Y or Yf tiling for interlaced modes. In
> > kms_flip_tiling test case
> > we are missing such a check. Let's add a requirement that whenever
> > we try to do flip with Y/Yf
> > tiling, we ensure that we have non-interlaced mode selected.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110772
> >
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > ---
> > tests/kms_flip_tiling.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/tests/kms_flip_tiling.c b/tests/kms_flip_tiling.c
> > index d1e6687f..582af53c 100644
> > --- a/tests/kms_flip_tiling.c
> > +++ b/tests/kms_flip_tiling.c
> > @@ -75,6 +75,14 @@ test_flip_tiling(data_t *data, enum pipe pipe,
> > igt_output_t *output, uint64_t ti
> > igt_output_set_pipe(output, pipe);
> >
> > mode = igt_output_get_mode(output);
> > +
> > + /* Interlaced modes don't support Y/Yf tiling */
> > + if (tiling[0] == LOCAL_I915_FORMAT_MOD_Y_TILED ||
> > + tiling[0] == LOCAL_I915_FORMAT_MOD_Yf_TILED ||
> > + tiling[1] == LOCAL_I915_FORMAT_MOD_Y_TILED ||
> > + tiling[1] == LOCAL_I915_FORMAT_MOD_Yf_TILED)
> > + igt_require(!(mode->flags & DRM_MODE_FLAG_INTERLACE));
> > +
>
> Any test using Y/Yf could hit this. But can't really think of
> generic place that could handle this (apart from TEST_ONLY
> which is probably how some tests would skip this).
That's true. Maybe we could create a library routine to check these.

Thanks for the review!

The patch is now pushed to IGT.

>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> > primary = igt_output_get_plane(output, 0);
> >
> > width = mode->hdisplay;
> > --
> > 2.17.1
> >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
>
>