Re: [igt-dev] [PATCH i-g-t v2 5/5] test/prime_vgem: use the gem_engine_topology library

Andi Shyti
2019-06-06T14:17:02Z

Hi Ram,

just a nitpick

> - execbuf.flags = ring | flags;
> + execbuf.flags = e ? e->flags : I915_EXEC_DEFAULT;

Because we are moving to the new engine naming, the
"I915_EXEC_DEFAULT" engine, conceptually, should not be used.

Politically, with Tvrtko, we agreed that he default engine now
is "I915_ENGINE_CLASS_RENDER", it's not the best as solution, but
works.

The rest looks good.

Reviewed-by: Andi Shyti <andi.shyti@intel.com>

Thanks,
Andi