Re: [igt-dev] [PATCH i-g-t v2 5/5] test/prime_vgem: use the gem_engine_topology library

Andi Shyti
2019-06-07T10:34:25Z

On Thu, Jun 06, 2019 at 03:38:36PM +0100, Tvrtko Ursulin wrote:
>
> On 06/06/2019 15:17, Andi Shyti wrote:
> > Hi Ram,
> >
> > just a nitpick
> >
> > > - execbuf.flags = ring | flags;
> > > + execbuf.flags = e ? e->flags : I915_EXEC_DEFAULT;
> >
> > Because we are moving to the new engine naming, the
> > "I915_EXEC_DEFAULT" engine, conceptually, should not be used.
> >
> > Politically, with Tvrtko, we agreed that he default engine now
> > is "I915_ENGINE_CLASS_RENDER", it's not the best as solution, but
> > works.
>
> I totally don't remember I ever suggested to use class or even it was
> discussed. :) Didn't we say to just use zero?

in one of the 25 reviews we agreed o that, but yes, '0' looks
better.