From: Simon Ser <simon.ser@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: martin.peres@intel.com
Subject: [igt-dev] [PATCH i-g-t v2 0/3] Check for audio noise and pops
Date: Tue, 4 Jun 2019 14:48:33 +0300 [thread overview]
Message-ID: <20190604114836.2830-1-simon.ser@intel.com> (raw)
This series is a continuation of "Add igt_audio self-tests and check for
noise/pops". Comments have been addressed on the last two patches of that
series, and a new commit adds a new phaseshift test.
In my real-world tests the power for these low frequencies go up to 0.0001 for
DisplayPort. In the self-tests a 0.0005 threshold detects a phaseshift of at
least 4 samples. Lowering the threshold to 0.0002 isn't enough to detect
phaseshifts with a lower number of samples. Thus I still think a 0.0005
threshold is reasonable.
The phaseshift self-test truncates 8 samples, just so that we have some freedom
if we want to change audio_signal_detect's logic. 8 samples is definitely a
very small phaseshift.
Simon Ser (3):
lib/igt_audio: detect noise and pops
lib/tests/igt_audio: add a pop test
lib/tests/igt_audio: add phaseshift detection test
lib/igt_audio.c | 58 ++++++++++++++++++++++++++++++++++++++----
lib/tests/igt_audio.c | 59 +++++++++++++++++++++++++++++++++++++++++++
2 files changed, 112 insertions(+), 5 deletions(-)
--
2.21.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2019-06-04 11:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 11:48 Simon Ser [this message]
2019-06-04 11:48 ` [igt-dev] [PATCH i-g-t v2 1/3] lib/igt_audio: detect noise and pops Simon Ser
2019-06-04 12:52 ` Martin Peres
2019-06-04 11:48 ` [igt-dev] [PATCH i-g-t v2 2/3] lib/tests/igt_audio: add a pop test Simon Ser
2019-06-04 12:54 ` Martin Peres
2019-06-05 8:03 ` [igt-dev] [PATCH i-g-t v3] lib/tests/igt_audio: add a test holding a sample Simon Ser
2019-06-12 10:56 ` Martin Peres
2019-06-04 11:48 ` [igt-dev] [PATCH i-g-t v2 3/3] lib/tests/igt_audio: add phaseshift detection test Simon Ser
2019-06-04 13:01 ` Martin Peres
2019-06-04 12:23 ` [igt-dev] ✓ Fi.CI.BAT: success for Check for audio noise and pops Patchwork
2019-06-04 23:39 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-06-05 10:48 ` [igt-dev] ✓ Fi.CI.BAT: success for Check for audio noise and pops (rev2) Patchwork
2019-06-06 14:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604114836.2830-1-simon.ser@intel.com \
--to=simon.ser@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=martin.peres@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox