Re: [igt-dev] [PATCH i-g-t] perf_pmu: Actually require engines again

Andi Shyti
2019-06-05T11:27:52Z

Hi,

> > > > igt_subtest_group {
> > > > igt_fixture {
> > > > - gem_context_has_engine(fd, 0, e->flags);
> > > > + igt_require(gem_context_has_engine(fd, 0, e->flags));
> > >
> > > Hmmm.. is the line even needed? I think iterator will only contain available
> > > engines.
> >
> >
> > Good question, looks like no.
> >
> > Does the iterator only give available engines on ye olde kernels too?
>
> There is a gem_has_ring in gem_engine_topology.c/intel_init_engine_list on
> the legacy path so I think it filters them there as well.
>
> Andi?

yes, indeed, what exactly is the issue?

Thanks,
Andi