Re: [igt-dev] [PATCH i-g-t] perf_pmu: Actually require engines again

Tvrtko Ursulin
2019-06-05T12:07:00Z

On 05/06/2019 12:27, Andi Shyti wrote:
> Hi,
>
>>>>> igt_subtest_group {
>>>>> igt_fixture {
>>>>> - gem_context_has_engine(fd, 0, e->flags);
>>>>> + igt_require(gem_context_has_engine(fd, 0, e->flags));
>>>>
>>>> Hmmm.. is the line even needed? I think iterator will only contain available
>>>> engines.
>>>
>>>
>>> Good question, looks like no.
>>>
>>> Does the iterator only give available engines on ye olde kernels too?
>>
>> There is a gem_has_ring in gem_engine_topology.c/intel_init_engine_list on
>> the legacy path so I think it filters them there as well.
>>
>> Andi?
>
> yes, indeed, what exactly is the issue?

I don't know if there was an actual issue but at least Petri found some
dead code as you can see in the patch.

Discussion was whether his patch should be applied or updated to remove
those lines altogether.

Regards,

Tvrtko