Re: [igt-dev] [PATCH i-g-t] perf_pmu: Actually require engines again

Petri Latvala
2019-06-05T12:32:27Z

On Wed, Jun 05, 2019 at 03:03:48PM +0300, Petri Latvala wrote:
> On Wed, Jun 05, 2019 at 02:27:50PM +0300, Andi Shyti wrote:
> > Hi,
> >
> > > > > > igt_subtest_group {
> > > > > > igt_fixture {
> > > > > > - gem_context_has_engine(fd, 0, e->flags);
> > > > > > + igt_require(gem_context_has_engine(fd, 0, e->flags));
> > > > >
> > > > > Hmmm.. is the line even needed? I think iterator will only contain available
> > > > > engines.
> > > >
> > > >
> > > > Good question, looks like no.
> > > >
> > > > Does the iterator only give available engines on ye olde kernels too?
> > >
> > > There is a gem_has_ring in gem_engine_topology.c/intel_init_engine_list on
> > > the legacy path so I think it filters them there as well.
> > >
> > > Andi?
> >
> > yes, indeed, what exactly is the issue?
>
> Whether gem_context_has_engine check is needed inside the
> __for_each_physical_engine loop, for any kernel.

Andi confirmed here that indeed, for any kernel, etc.

--
Petri Latvala