From: Petri Latvala <petri.latvala@intel.com>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [igt-dev] [PATCH i-g-t] runner: Also consider TAINT_MACHINE_CHECK as abortable taint
Date: Wed, 5 Jun 2019 15:57:03 +0300 [thread overview]
Message-ID: <20190605125703.GJ22949@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <87zhmwqjuq.fsf@gaia.fi.intel.com>
On Wed, Jun 05, 2019 at 03:47:57PM +0300, Mika Kuoppala wrote:
> Daniel Vetter <daniel@ffwll.ch> writes:
>
> > On Wed, Jun 05, 2019 at 03:16:07PM +0300, Petri Latvala wrote:
> >> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> >> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> >
> > I've seen lots of machines where these happen as normal side-effect of
> > thermal throtlling. For some value of "normal".
> >
>
> Thermals could be ok and filtered if we can be somewhat certain that
> the state didn't suffer. Can we?
>
> > Do we really want to reboot on these? It could be like the network thing I
> > recently disabled, and then everyone started screaming because our
> > machines where constantly rebooting due to network cards/drivers
> > temporarily having a bad time (but usually recovering).
>
> Reboot? This won't get fixed by reboot as the hw is busted.
>
> The question is that is it fruitful to weed out software
> failures with a broken hardware.
Yeah, I forgot to mention this aspect.
We don't want to just reboot on this: We want to
1) never file a cibuglog filter on TAINT_MACHINE_CHECK. We want that to always be critical.
2) if we get that abort, replace the hw.
Whether that's possible depends on when/if we get that particular taint happening...
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-06-05 12:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 12:16 [igt-dev] [PATCH i-g-t] runner: Also consider TAINT_MACHINE_CHECK as abortable taint Petri Latvala
2019-06-05 12:36 ` Daniel Vetter
2019-06-05 12:47 ` Mika Kuoppala
2019-06-05 12:57 ` Petri Latvala [this message]
2019-06-05 12:53 ` Petri Latvala
2019-06-05 16:54 ` Daniel Vetter
2019-06-05 12:40 ` Mika Kuoppala
2019-06-05 13:02 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-06-06 19:21 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605125703.GJ22949@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=daniel@ffwll.ch \
--cc=igt-dev@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox