Re: [igt-dev] [PATCH i-g-t v2 3/5] test/i915: gem_exec_capture: use the gem_engine_topology library

Ramalingam C
2019-05-30T15:57:11Z

On 2019-05-30 at 16:47:35 +0100, Chris Wilson wrote:
> Quoting Ramalingam C (2019-05-30 16:42:20)
> > @@ -501,7 +502,7 @@ static void userptr(int fd, int dir)
> > igt_assert(posix_memalign(&ptr, 4096, 4096) == 0);
> > igt_require(__gem_userptr(fd, ptr, 4096, 0, 0, &handle) == 0);
> >
> > - __capture1(fd, dir, 0, handle);
> > + __capture1(fd, dir, NULL, handle);
>
> You're missing something here. Using the new iterator NULL results in a
> random engine.
Chris,

engine pointer is passed into __capture1() and following delta handles
the flags for execbuf.
- execbuf.flags = ring;
+ execbuf.flags = e ? e->flags : 0;

Will this be fine?

-Ram
> -Chris