public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Guillaume Tucker <guillaume.tucker@collabora.com>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>,
	Petri Latvala <petri.latvala@intel.com>,
	"Ser, Simon" <simon.ser@intel.com>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH i-g-t v3 1/4] meson: add libatomic dependency
Date: Tue, 18 Jun 2019 13:27:43 +0100	[thread overview]
Message-ID: <20190618122746.61310-2-guillaume.tucker@collabora.com> (raw)
In-Reply-To: <20190618122746.61310-1-guillaume.tucker@collabora.com>

Add conditional dependency on libatomic in order to be able to use the
__atomic_* functions instead of the older __sync_* ones.  The
libatomic library is only needed when there aren't any native support
on the current architecture, so a linker test is used for this
purpose.  This enables atomic operations to be on a wider number of
architectures including MIPS.

Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
---

Notes:
    v2: add linker test for libatomic
    v3: use null_dep

 meson.build | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/meson.build b/meson.build
index 6268c58d3634..118ad667ffb5 100644
--- a/meson.build
+++ b/meson.build
@@ -180,6 +180,20 @@ realtime = cc.find_library('rt')
 dlsym = cc.find_library('dl')
 zlib = cc.find_library('z')
 
+if cc.links('''
+#include <stdint.h>
+int main(void) {
+  uint32_t x32 = 0;
+  uint64_t x64 = 0;
+  __atomic_load_n(&x32, __ATOMIC_SEQ_CST);
+  __atomic_load_n(&x64, __ATOMIC_SEQ_CST);
+  return 0;
+}''', name : 'built-in atomics')
+	libatomic = null_dep
+else
+	libatomic = cc.find_library('atomic')
+endif
+
 if cc.has_header('linux/kd.h')
 	config.set('HAVE_LINUX_KD_H', 1)
 endif
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-06-18 12:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-18 12:27 [igt-dev] [PATCH i-g-t v3 0/4] Use C11 atomics Guillaume Tucker
2019-06-18 12:27 ` Guillaume Tucker [this message]
2019-06-18 13:20   ` [igt-dev] [PATCH i-g-t v3 1/4] meson: add libatomic dependency Ser, Simon
2019-06-18 13:59     ` Guillaume Tucker
2019-06-18 14:37       ` Ser, Simon
2019-06-18 16:03         ` Guillaume Tucker
2019-06-19  6:42           ` Ser, Simon
2019-06-19  7:24             ` Guillaume Tucker
2019-06-18 12:27 ` [igt-dev] [PATCH i-g-t v3 2/4] gitlab-ci: add libatomic to docker images Guillaume Tucker
2019-06-19  6:50   ` Ser, Simon
2019-06-19  8:09     ` Guillaume Tucker
2019-06-18 12:27 ` [igt-dev] [PATCH i-g-t v3 3/4] i915/gem_create: use atomic_* instead of __sync_* Guillaume Tucker
2019-06-18 12:27 ` [Intel-gfx] [PATCH i-g-t v3 4/4] tests/sw_sync: " Guillaume Tucker
2019-06-18 13:31 ` [igt-dev] ✗ Fi.CI.BAT: failure for Use C11 atomics (rev2) Patchwork
2019-06-19  6:52   ` Ser, Simon
2019-06-19  7:02     ` Saarinen, Jani
2019-06-19  7:32       ` Peres, Martin
2019-06-19  7:46         ` Guillaume Tucker
2019-06-19  8:05 ` [igt-dev] ✓ Fi.CI.BAT: success for Use C11 atomics (rev3) Patchwork
2019-06-19 21:21 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190618122746.61310-2-guillaume.tucker@collabora.com \
    --to=guillaume.tucker@collabora.com \
    --cc=arkadiusz.hiler@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    --cc=simon.ser@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox