From: Simon Ser <simon.ser@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: martin.peres@intel.com
Subject: [igt-dev] [PATCH i-g-t 1/2] lib/igt_eld: fix potential read from undefined value
Date: Tue, 18 Jun 2019 15:55:42 +0300 [thread overview]
Message-ID: <20190618125543.646-1-simon.ser@intel.com> (raw)
If the ELD doesn't contain a monitor_present line (this shouldn't happen), then
the value is garbage. Define the variable as a safety net.
Signed-off-by: Simon Ser <simon.ser@intel.com>
---
lib/igt_eld.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/igt_eld.c b/lib/igt_eld.c
index 15dd8ac95189..3d7fd4dd0a82 100644
--- a/lib/igt_eld.c
+++ b/lib/igt_eld.c
@@ -152,7 +152,7 @@ static bool eld_parse_entry(const char *path, struct eld_entry *eld)
char buf[1024];
char *key, *value, *sad_key;
size_t len;
- bool monitor_present;
+ bool monitor_present = false;
int sad_index;
memset(eld, 0, sizeof(*eld));
--
2.22.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2019-06-18 12:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 12:55 Simon Ser [this message]
2019-06-18 12:55 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_chamelium: fix read from uninitialized value in flatline audio test Simon Ser
2019-06-18 13:01 ` Peres, Martin
2019-06-18 13:01 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_eld: fix potential read from undefined value Peres, Martin
2019-06-18 14:18 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
2019-06-19 2:16 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618125543.646-1-simon.ser@intel.com \
--to=simon.ser@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=martin.peres@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox