From: Petri Latvala <petri.latvala@intel.com>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 3/3] runner/settings: Be consistent with empty blacklist
Date: Thu, 20 Jun 2019 15:34:17 +0300 [thread overview]
Message-ID: <20190620123417.GI22949@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20190620122902.20761-3-arkadiusz.hiler@intel.com>
On Thu, Jun 20, 2019 at 03:29:02PM +0300, Arkadiusz Hiler wrote:
> If provided an empty blacklist let's fail instead of returning a value
> of uninitialized variable.
>
> Cc: Oleg Vasilev <oleg.vasilev@intel.com>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> ---
> runner/settings.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/runner/settings.c b/runner/settings.c
> index 9920e1a6..8b39c063 100644
> --- a/runner/settings.c
> +++ b/runner/settings.c
> @@ -227,7 +227,7 @@ static bool parse_blacklist(struct regex_list *exclude_regexes,
> FILE *f;
> char *line = NULL;
> size_t line_len = 0;
> - bool status;
> + bool status = false;
>
> if ((f = fopen(blacklist_filename, "r")) == NULL) {
> fprintf(stderr, "Cannot open blacklist file %s\n", blacklist_filename);
> --
> 2.21.0
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-06-20 12:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 12:29 [igt-dev] [PATCH i-g-t 1/3] runner/executor: Make sure that intervals_left is always initialized Arkadiusz Hiler
2019-06-20 12:29 ` [igt-dev] [PATCH i-g-t 2/3] runner/resultgen: Don't pass NULL to str*() functions Arkadiusz Hiler
2019-06-20 12:33 ` Petri Latvala
2019-06-20 12:29 ` [igt-dev] [PATCH i-g-t 3/3] runner/settings: Be consistent with empty blacklist Arkadiusz Hiler
2019-06-20 12:34 ` Petri Latvala [this message]
2019-06-20 12:33 ` [igt-dev] [PATCH i-g-t 1/3] runner/executor: Make sure that intervals_left is always initialized Petri Latvala
2019-06-20 16:50 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] " Patchwork
2019-06-20 19:15 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620123417.GI22949@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox