Re: [igt-dev] [RFC v2 01/43] test/i915: gem_bad_reloc: use the gem_engine_topology library

Chris Wilson
2019-06-21T10:51:57Z

Quoting Tvrtko Ursulin (2019-06-21 11:05:46)
>
> On 21/06/2019 11:02, Chris Wilson wrote:
> > Quoting Ramalingam C (2019-06-21 11:03:03)
> >> @@ -193,12 +193,12 @@ igt_main
> >> igt_require_gem(fd);
> >> }
> >>
> >> - for (e = intel_execution_engines; e->name; e++) {
> >> + __for_each_physical_engine(fd, e) {
> >
> > uABI testing not physical engines.
>
> Should we add something like for_each_legacy_abi_engine to use in these
> tests so it is more self-documenting? (And get rid of raw access to
> intel_execution_engines.)

Yes, a for_each_legacy_abi_engine would be most welcome. The basic
parameter testing should exist for both . Above that I would like to
keep some basic behavioural checking sufficient so that we can be
confident that yesterday's mesa/etc keeps on working on tomorrow's
kernel. After that, so long as we can say "we can tested this behaviour
with the new ABI and have proven the equivalence via this and this test,
ergo we can be confident the legacy ABI will work (if applicable)".
-Chris